Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set admin names on Admin LTE #30

Closed
wants to merge 2 commits into from
Closed

Set admin names on Admin LTE #30

wants to merge 2 commits into from

Conversation

blomdahldaniel
Copy link
Contributor

As much as I love you and the repo Rappa, I would very much like to not have to change this every other time i clone your repo.

What do you think?

@blomdahldaniel
Copy link
Contributor Author

Sorry for not putting them in the same commit, it was such a small change so i did it here threw github and i didnt know how to make it propely..

@rappasoft
Copy link
Owner

I think it should use the access wrapper, you can replace those with access()->user()->name and it should do the same. Then I can merge it in.

@blomdahldaniel
Copy link
Contributor Author

Okey so how and why the access wrappers? Just the syntax you would like in your reop or is there something other more useful in mind of that?

@rappasoft
Copy link
Owner

The access wrapper provides access to the user control management system, plus it would keep it consistent. It is literally Auth::user()->name anyway. But with access you can do access()->can() access()->hasRole(), etc.

@blomdahldaniel
Copy link
Contributor Author

Aah, I see! Great, now I created a new pull request with the 2 file changes in the same branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants