-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed a UI bug where the table header + column selector has slight white pixels on top #1545
Conversation
Add Initial Lifecycle Hooks - Configuring/Configured by @lrljoe in v3 - Initial Lifecycle Hooks - Configuring/Configured rappasoft#1520 Add "HasAllTraits" for Maintainability by @lrljoe in v3 - Splitting Codebase - ConfigurableAreas, CollapsingColumns and TableAttributes rappasoft#1514 Rename row-contents blades for clarity by @lrljoe in V3 Rename row-contents blades rappasoft#1519 Add missing tests for DateFilter and DateTimeFilter by @lrljoe in V3 Adds missing tests for DateTimeFilter and DateFilter rappasoft#1527
Update Changelog
Develop to Master 3.1.2
- Add additional Lifecycle Hook by @lrljoe in rappasoft#1534 - SettingColumns/ColumnsSet - Migrate methods for pre-render out of render by @lrljoe in rappasoft#1534 - Update tests to reflect hooks by @lrljoe in rappasoft#1534 - Update tests to add invalid string tests for dates by @lrljoe in rappasoft#1534 - Remove maps and minimise functions from FrontendAssets by @lrljoe in rappasoft#1534
Develop to Master - Workflows Only
Cheers for the PR, I'll review this coming weekend and merge in |
Changed base to develop, approved check runs. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1545 +/- ##
==========================================
Coverage 88.98% 88.98%
Complexity 1264 1264
==========================================
Files 96 96
Lines 2997 2997
==========================================
Hits 2667 2667
Misses 330 330 ☔ View full report in Codecov by Sentry. |
@CorwinDev - this PR removes the default bg-gray-50 from the thead This changes the default behaviour from: You can note that the table head is no longer grey/gray by default, however, the bulk actions retains the background. Think the bg-gray-50 needs to stay, but agree around the other adjustment. |
Will double check this in dev shortly, and merge into develop ahead of next release if working. |
All Submissions:
Changes