Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed a UI bug where the table header + column selector has slight white pixels on top #1545

Merged
merged 8 commits into from
Nov 19, 2023

Conversation

CorwinDev
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes

  • Removed a UI bug where the table header + column selector has slight white pixels on top
    image
    image

lrljoe and others added 7 commits November 3, 2023 16:02
Add Initial Lifecycle Hooks - Configuring/Configured by @lrljoe in v3 - Initial Lifecycle Hooks - Configuring/Configured rappasoft#1520
Add "HasAllTraits" for Maintainability by @lrljoe in v3 - Splitting Codebase - ConfigurableAreas, CollapsingColumns and TableAttributes rappasoft#1514
Rename row-contents blades for clarity by @lrljoe in V3 Rename row-contents blades rappasoft#1519
Add missing tests for DateFilter and DateTimeFilter by @lrljoe in V3 Adds missing tests for DateTimeFilter and DateFilter rappasoft#1527
- Add additional Lifecycle Hook by @lrljoe in rappasoft#1534
  - SettingColumns/ColumnsSet
- Migrate methods for pre-render out of render by @lrljoe in rappasoft#1534
- Update tests to reflect hooks by @lrljoe in rappasoft#1534
- Update tests to add invalid string tests for dates by @lrljoe in rappasoft#1534
- Remove maps and minimise functions from FrontendAssets by @lrljoe in rappasoft#1534
Develop to Master - Workflows Only
@lrljoe
Copy link
Sponsor Collaborator

lrljoe commented Nov 9, 2023

Cheers for the PR, I'll review this coming weekend and merge in

@lrljoe lrljoe changed the base branch from master to develop November 15, 2023 00:17
@lrljoe
Copy link
Sponsor Collaborator

lrljoe commented Nov 15, 2023

Changed base to develop, approved check runs.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc4bfa3) 88.98% compared to head (ad34e2b) 88.98%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1545   +/-   ##
==========================================
  Coverage      88.98%   88.98%           
  Complexity      1264     1264           
==========================================
  Files             96       96           
  Lines           2997     2997           
==========================================
  Hits            2667     2667           
  Misses           330      330           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe
Copy link
Sponsor Collaborator

lrljoe commented Nov 15, 2023

@CorwinDev - this PR removes the default bg-gray-50 from the thead

This changes the default behaviour from:
image

To
image

You can note that the table head is no longer grey/gray by default, however, the bulk actions retains the background.

Think the bg-gray-50 needs to stay, but agree around the other adjustment.

@lrljoe lrljoe added bug Something isn't working In Progress I've started diagnosing a fix labels Nov 15, 2023
@lrljoe
Copy link
Sponsor Collaborator

lrljoe commented Nov 19, 2023

Will double check this in dev shortly, and merge into develop ahead of next release if working.

@lrljoe lrljoe merged commit db0689d into rappasoft:develop Nov 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working In Progress I've started diagnosing a fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants