Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing tailwind background colour class for when hovering over the clear button in dark mode. #1553

Merged
merged 6 commits into from
Nov 15, 2023

Conversation

slakbal
Copy link
Contributor

@slakbal slakbal commented Nov 13, 2023

Change

  • Added missing tailwindcss class for when hovering over the clear button for the filters when in dark mode.

lrljoe and others added 6 commits November 3, 2023 16:02
Add Initial Lifecycle Hooks - Configuring/Configured by @lrljoe in v3 - Initial Lifecycle Hooks - Configuring/Configured rappasoft#1520
Add "HasAllTraits" for Maintainability by @lrljoe in v3 - Splitting Codebase - ConfigurableAreas, CollapsingColumns and TableAttributes rappasoft#1514
Rename row-contents blades for clarity by @lrljoe in V3 Rename row-contents blades rappasoft#1519
Add missing tests for DateFilter and DateTimeFilter by @lrljoe in V3 Adds missing tests for DateTimeFilter and DateFilter rappasoft#1527
- Add additional Lifecycle Hook by @lrljoe in rappasoft#1534
  - SettingColumns/ColumnsSet
- Migrate methods for pre-render out of render by @lrljoe in rappasoft#1534
- Update tests to reflect hooks by @lrljoe in rappasoft#1534
- Update tests to add invalid string tests for dates by @lrljoe in rappasoft#1534
- Remove maps and minimise functions from FrontendAssets by @lrljoe in rappasoft#1534
Develop to Master - Workflows Only
@slakbal slakbal changed the title Added missing tailwind background colour for hover in dark mode. Added missing tailwind background colour class for when hovering over the clear button in dark mode. Nov 13, 2023
@lrljoe lrljoe changed the base branch from master to develop November 15, 2023 00:14
@lrljoe
Copy link
Sponsor Collaborator

lrljoe commented Nov 15, 2023

Thanks for the commit, it looks super simple, so I'll give it a once-over this week and merge in with other PRs ahead of next release.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc4bfa3) 88.98% compared to head (118ff54) 88.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1553   +/-   ##
==========================================
  Coverage      88.98%   88.98%           
  Complexity      1264     1264           
==========================================
  Files             96       96           
  Lines           2997     2997           
==========================================
  Hits            2667     2667           
  Misses           330      330           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 0ab854c into rappasoft:develop Nov 15, 2023
6 checks passed
@lrljoe
Copy link
Sponsor Collaborator

lrljoe commented Nov 15, 2023

Merged into develop, will be part of next release.

@lrljoe lrljoe mentioned this pull request Dec 4, 2023
9 tasks
lrljoe added a commit that referenced this pull request Dec 4, 2023
## [v3.1.4] - 2023-12-04
### New Features
- Add capability to hide Column Label by @lrljoe in #1512
- Add capability to set a custom script path for the scripts/styles by @lrljoe in #1557
- Added rowsRetrieved Lifecycle Hook, expanded documentation for Lifecycle Hooks

### Bug Fixes
- Added missing tailwind background colour class for when hovering over the clear button in dark mode by @slakbal in #1553
- Fixed extraneous space in config.php by @viliusvsx in in #1577
- Changed table default vertical overflow to auto by @dmyers in #1573
- Fix footer rendering issue with extra td displayed depending on bulk action statuses

### Tweaks
- Create additional Exception Classes (NoColumnsException, NoSearchableColumnsException, NoSortableColumnsException)
- Revert previous splitting of JS Files
- Add capability to customise Bulk Actions Styling with tests by @lrljoe in #1564
  - TH Classes
  - TH Checkbox Classes
  - TD Classes
  - TD Checkbox Classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants