Fix missing typehints #1757

lrljoe · 2024-07-03T20:46:12Z

This PR is ongoing development, and is to add missing typehints, and returntypes.

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

Does your submission pass tests and did you add any new tests needed for your feature?
Did you update all templates (if applicable)?
Did you add the relevant documentation (if applicable)?
Did you test locally to make sure your feature works as intended?

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

…ollection, add typehint for empty

…del to be used longer term)

codecov · 2024-07-03T22:13:26Z

Codecov Report

Attention: Patch coverage is 77.41935% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (development@f0cfe56). Learn more about missing BASE report.

Files	Patch %	Lines
src/Commands/MakeCommand.php	0.00%	4 Missing ⚠️
src/Traits/WithEvents.php	0.00%	2 Missing ⚠️
src/Traits/WithPagination.php	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff               @@
##             development    #1757   +/-   ##
==============================================
  Coverage               ?   85.56%           
  Complexity             ?     1384           
==============================================
  Files                  ?      127           
  Lines                  ?     3264           
  Branches               ?        0           
==============================================
  Hits                   ?     2793           
  Misses                 ?      471           
  Partials               ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Adjust for HTML Columns * Update ChangeLog and SP * fix: Apply cursor pointer only on clickable columns when using Bootst… (#1742) * Ensure HTML Columns Return HTML Correctly (#1737) * Adjust for HTML Columns * fix: Apply cursor pointer only on clickable columns when using Bootstrap --------- Co-authored-by: Joe <104938042+lrljoe@users.noreply.github.com> * Fix styling * Fix hide bulk actions when empty not reflecting in frontend (#1747) * Fix issue with Hide Bulk Actions When Empty not reflecting in frontend * Fix styling * Add development branch into tests --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Change Return Type for attributes() to static (#1749) * Switch to using Composer\InstalledVersions for AboutCommand to reduce necessity to update ServiceProvider with each update (#1748) * Two improvements to improve typehinting, migrate to larastan/larastan, cleanup of test (#1750) * Add ArrayColumn (BETA) (#1751) * Add ArrayColumn * Fix styling --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Always hide bulk actions option (#1752) * Add option to "Always Hide Bulk Actions" * Fix styling * Fix test function name clash --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Optionally disable count for simple pagination (#1755) * Add option for setShouldRetrieveTotalItemCountStatus * Fix styling --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Update ChangeLog For 3.2.8 Release (#1754) * Update ChangeLog for 3.2.8 * Add release date * Fix phpstan unescaped | * Fix missing typehints (#1757) * Add additional typehints * Fix styling * Add filterCollection typehint * Fix styling * trUrlCallback fixes * Use Collection rather than collect() helper * Fix styling * Add ignore for "Unable to resolve the template type" for Illuminate Collection, add typehint for empty * Add ignore for $model has no defined type (allows for non Eloquent Model to be used longer term) * Adjust concurrency * Adjust Test * Adjust Again * Adjust PHPStan * Add Max Parallel * Use v4 of checkout/cache * Run one at a time * Add Clear Cache Workflow * Fix * Migrate to v4 and adjust workflows * Adjust workflow run rules * Adjust Run-Tests to separate L10 and L11 jobs * Adjust run-tests * Adjust Test * Add Laravel matrix * Adjust Concurrency * Adjust * Adjust Pull Jobs to Match Push jobs --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> --------- Co-authored-by: Matt Pickering <mattukp+gh@gmail.com> Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Update ChangeLog For 3.2.8 Release (rappasoft#1754) * Update ChangeLog for 3.2.8 * Add release date * Fix phpstan unescaped | * Fix missing typehints (rappasoft#1757) * Add additional typehints * Fix styling * Add filterCollection typehint * Fix styling * trUrlCallback fixes * Use Collection rather than collect() helper * Fix styling * Add ignore for "Unable to resolve the template type" for Illuminate Collection, add typehint for empty * Add ignore for $model has no defined type (allows for non Eloquent Model to be used longer term) * Adjust concurrency * Adjust Test * Adjust Again * Adjust PHPStan * Add Max Parallel * Use v4 of checkout/cache * Run one at a time * Add Clear Cache Workflow * Fix * Migrate to v4 and adjust workflows * Adjust workflow run rules * Adjust Run-Tests to separate L10 and L11 jobs * Adjust run-tests * Adjust Test * Add Laravel matrix * Adjust Concurrency * Adjust * Adjust Pull Jobs to Match Push jobs --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Adjust for HTML Columns * Update ChangeLog and SP * fix: Apply cursor pointer only on clickable columns when using Bootst… (#1742) * Ensure HTML Columns Return HTML Correctly (#1737) * Adjust for HTML Columns * fix: Apply cursor pointer only on clickable columns when using Bootstrap --------- Co-authored-by: Joe <104938042+lrljoe@users.noreply.github.com> * Fix styling * Fix hide bulk actions when empty not reflecting in frontend (#1747) * Fix issue with Hide Bulk Actions When Empty not reflecting in frontend * Fix styling * Add development branch into tests --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Change Return Type for attributes() to static (#1749) * Switch to using Composer\InstalledVersions for AboutCommand to reduce necessity to update ServiceProvider with each update (#1748) * Two improvements to improve typehinting, migrate to larastan/larastan, cleanup of test (#1750) * Add ArrayColumn (BETA) (#1751) * Add ArrayColumn * Fix styling --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Always hide bulk actions option (#1752) * Add option to "Always Hide Bulk Actions" * Fix styling * Fix test function name clash --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Optionally disable count for simple pagination (#1755) * Add option for setShouldRetrieveTotalItemCountStatus * Fix styling --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Update ChangeLog For 3.2.8 Release (#1754) * Update ChangeLog for 3.2.8 * Add release date * Fix phpstan unescaped | * Fix missing typehints (#1757) * Add additional typehints * Fix styling * Add filterCollection typehint * Fix styling * trUrlCallback fixes * Use Collection rather than collect() helper * Fix styling * Add ignore for "Unable to resolve the template type" for Illuminate Collection, add typehint for empty * Add ignore for $model has no defined type (allows for non Eloquent Model to be used longer term) * Adjust concurrency * Adjust Test * Adjust Again * Adjust PHPStan * Add Max Parallel * Use v4 of checkout/cache * Run one at a time * Add Clear Cache Workflow * Fix * Migrate to v4 and adjust workflows * Adjust workflow run rules * Adjust Run-Tests to separate L10 and L11 jobs * Adjust run-tests * Adjust Test * Add Laravel matrix * Adjust Concurrency * Adjust * Adjust Pull Jobs to Match Push jobs --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Add CountColumn, simpler adding of WithCounts, With (#1761) * Initial Commit * Adjust CountColumn * Add ExtraWiths * Add AggregateColumn * Add SumColumn * Update Docs - Add Column Types Section * Add exceptions for empty data source, add standard tests * Ensure pcov runs on push to master/development/develop * Update to use codecov v4 --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Add Option to Retain Selected when Searching/Filtering (#1762) * Initial Commit for Retaining Selected * Update Test for Search/Filter --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Add WireLink Column (#1763) * Add WireLinkColumn * Add Tests for WireLinkColumn --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Fix styling --------- Co-authored-by: Matt Pickering <mattukp+gh@gmail.com> Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

* Adjust for HTML Columns * Update ChangeLog and SP * fix: Apply cursor pointer only on clickable columns when using Bootst… (#1742) * Ensure HTML Columns Return HTML Correctly (#1737) * Adjust for HTML Columns * fix: Apply cursor pointer only on clickable columns when using Bootstrap --------- Co-authored-by: Joe <104938042+lrljoe@users.noreply.github.com> * Fix styling * Fix hide bulk actions when empty not reflecting in frontend (#1747) * Fix issue with Hide Bulk Actions When Empty not reflecting in frontend * Fix styling * Add development branch into tests --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Change Return Type for attributes() to static (#1749) * Switch to using Composer\InstalledVersions for AboutCommand to reduce necessity to update ServiceProvider with each update (#1748) * Two improvements to improve typehinting, migrate to larastan/larastan, cleanup of test (#1750) * Add ArrayColumn (BETA) (#1751) * Add ArrayColumn * Fix styling --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Always hide bulk actions option (#1752) * Add option to "Always Hide Bulk Actions" * Fix styling * Fix test function name clash --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Optionally disable count for simple pagination (#1755) * Add option for setShouldRetrieveTotalItemCountStatus * Fix styling --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Update ChangeLog For 3.2.8 Release (#1754) * Update ChangeLog for 3.2.8 * Add release date * Fix phpstan unescaped | * Fix missing typehints (#1757) * Add additional typehints * Fix styling * Add filterCollection typehint * Fix styling * trUrlCallback fixes * Use Collection rather than collect() helper * Fix styling * Add ignore for "Unable to resolve the template type" for Illuminate Collection, add typehint for empty * Add ignore for $model has no defined type (allows for non Eloquent Model to be used longer term) * Adjust concurrency * Adjust Test * Adjust Again * Adjust PHPStan * Add Max Parallel * Use v4 of checkout/cache * Run one at a time * Add Clear Cache Workflow * Fix * Migrate to v4 and adjust workflows * Adjust workflow run rules * Adjust Run-Tests to separate L10 and L11 jobs * Adjust run-tests * Adjust Test * Add Laravel matrix * Adjust Concurrency * Adjust * Adjust Pull Jobs to Match Push jobs --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Add CountColumn, simpler adding of WithCounts, With (#1761) * Initial Commit * Adjust CountColumn * Add ExtraWiths * Add AggregateColumn * Add SumColumn * Update Docs - Add Column Types Section * Add exceptions for empty data source, add standard tests * Ensure pcov runs on push to master/development/develop * Update to use codecov v4 --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Add Option to Retain Selected when Searching/Filtering (#1762) * Initial Commit for Retaining Selected * Update Test for Search/Filter --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Add WireLink Column (#1763) * Add WireLinkColumn * Add Tests for WireLinkColumn --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com> * Fix styling * Update ChangeLog --------- Co-authored-by: Matt Pickering <mattukp+gh@gmail.com> Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>

lrljoe and others added 27 commits July 3, 2024 21:39

Add additional typehints

f758593

Fix styling

d0f80f1

Add filterCollection typehint

40aeed4

Fix styling

2f31d48

trUrlCallback fixes

aca44b2

Use Collection rather than collect() helper

19268bc

Fix styling

f5569cc

Add ignore for "Unable to resolve the template type" for Illuminate C…

ef43e8d

…ollection, add typehint for empty

Add ignore for $model has no defined type (allows for non Eloquent Mo…

0ad6289

…del to be used longer term)

Adjust concurrency

26d03b1

Adjust Test

d7c8c67

Adjust Again

2b303e8

Adjust PHPStan

0d8e295

Add Max Parallel

d7122ee

Use v4 of checkout/cache

9be70dc

Run one at a time

46d4457

Add Clear Cache Workflow

8d698dc

Fix

4d7350a

Migrate to v4 and adjust workflows

ac815b9

Adjust workflow run rules

c069aa8

Adjust Run-Tests to separate L10 and L11 jobs

5d1f9b7

Adjust run-tests

7296e18

Adjust Test

02fe0e5

Add Laravel matrix

938a96e

Adjust Concurrency

5a9233e

Adjust

36afdb6

Adjust Pull Jobs to Match Push jobs

e82c7b2

lrljoe merged commit 51f4c94 into rappasoft:development Jul 3, 2024
8 of 9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix missing typehints #1757

Fix missing typehints #1757

lrljoe commented Jul 3, 2024

codecov bot commented Jul 3, 2024

Fix missing typehints #1757

Fix missing typehints #1757

Conversation

lrljoe commented Jul 3, 2024

All Submissions:

New Feature Submissions:

Changes to Core Features:

codecov bot commented Jul 3, 2024

Codecov Report