Fix code cache to make CREATE OR REPLACE FUNCTION to work.

expected/plv8.out

@@ -282,6 +282,21 @@ CREATE FUNCTION test_sql_error() RETURNS void AS $$ executeSql("ERROR") $$ LANGU
 SELECT test_sql_error();
 ERROR:  syntax error at or near "ERROR"
 DETAIL:  test_sql_error() LINE 1:  executeSql("ERROR") 
+-- REPLACE FUNCTION
+CREATE FUNCTION replace_test() RETURNS integer AS $$ return 1; $$ LANGUAGE plv8;
+SELECT replace_test();
+ replace_test 
+--------------
+            1
+(1 row)
+
+CREATE OR REPLACE FUNCTION replace_test() RETURNS integer AS $$ return 2; $$ LANGUAGE plv8;
+SELECT replace_test();
+ replace_test 
+--------------
+            2
+(1 row)
+
 -- TRIGGER
 CREATE FUNCTION test_trigger() RETURNS trigger AS
 $$

plv8.cc

@@ -472,6 +472,7 @@ plv8_get_proc_cache(Oid fn_oid, bool validate, char ***argnames) throw()
 				proc->prosrc = NULL;
 			}
 			proc->function.Dispose();
+			proc->function.Clear();
 		}
 		else
 		{
@@ -485,6 +486,8 @@ plv8_get_proc_cache(Oid fn_oid, bool validate, char ***argnames) throw()
 		proc->prosrc = NULL;
 	}
 
+	Assert(proc->function.IsEmpty());
+
 	procStruct = (Form_pg_proc) GETSTRUCT(procTup);
 
 	prosrc = SysCacheGetAttr(PROCOID, procTup, Anum_pg_proc_prosrc, &isnull);

sql/plv8.sql

@@ -152,6 +152,12 @@ SELECT * FROM return_sql();
 CREATE FUNCTION test_sql_error() RETURNS void AS $$ executeSql("ERROR") $$ LANGUAGE plv8;
 SELECT test_sql_error();
 
+-- REPLACE FUNCTION
+CREATE FUNCTION replace_test() RETURNS integer AS $$ return 1; $$ LANGUAGE plv8;
+SELECT replace_test();
+CREATE OR REPLACE FUNCTION replace_test() RETURNS integer AS $$ return 2; $$ LANGUAGE plv8;
+SELECT replace_test();
+
 -- TRIGGER
 CREATE FUNCTION test_trigger() RETURNS trigger AS
 $$