Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2.5 #59

Merged
merged 12 commits into from
Jul 9, 2019
Merged

v0.2.5 #59

merged 12 commits into from
Jul 9, 2019

Conversation

rasbt
Copy link
Member

@rasbt rasbt commented Jul 9, 2019

Description

Minor update that now includes the insertion codes in the PandasPdb.amino3to1 function to avoid potential bugs where relevant amino acids could be skipped

Related issues or pull requests

Fixes #58

Pull Request requirements

For new features or bug fixes, pleas consider the following to-do list:

  • Added appropriate unit test functions in the ./biopandas/*/tests directories
  • Ran nosetests ./biopandas -sv and make sure that all unit tests pass
  • Checked the test coverage by running nosetests ./biopandas --with-coverage
  • Checked for style issues by running flake8 ./biopandas
  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md` file
  • Modified documentation in the appropriate location under biopandas/docs/sources/ (optional)
  • Checked that the Travis-CI build passed at https://travis-ci.org/rasbt/biopandas

@pep8speaks
Copy link

pep8speaks commented Jul 9, 2019

Hello @rasbt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-07-09 20:13:49 UTC

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 94.236% when pulling 9a7e380 on v0.2.5 into 615a7cf on master.

@rasbt rasbt merged commit 3f78c91 into master Jul 9, 2019
nozomu-y pushed a commit to nozomu-y/biopandas that referenced this pull request Jan 9, 2023
* modernized setup.py

* include insertion codes in amino3to1

* pep8 fixes

* update conda command

* update travis config

* update travis installer scripts

* disable systemwide packages

* old conda style syntax to disable system conda

* use more recent conda installer

* fix conda install

* conda init

* conda init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ppdb.amino3to1()
3 participants