Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFrame input for SequentialFeatureSelector doesn't work for backward feature selection #505

Closed
daniel-sch opened this issue Feb 13, 2019 · 1 comment

Comments

@daniel-sch
Copy link
Contributor

daniel-sch commented Feb 13, 2019

When modifying Example 12 from the documentation by replacing forward=True with forward=False, an error gets raised. In a quick test, only forward=True, floating=False seems to work, all other combinations raise errors when the input is a DataFrame.

The error was TypeError: unhashable type: 'slice' before upgrading pandas to 0.24.1, now it is TypeError: '(slice(None, None, None), (0, 1, 2))' is an invalid key.

I think this was the underlying issue in #486, but this was closed, so I'm opening a new issue.

I'm using mlxtend 0.13.0, please let me know if you need any other information.

@daniel-sch
Copy link
Contributor Author

I think I just localized the error and I will create a PR shortly.

rasbt pushed a commit that referenced this issue Feb 16, 2019
…ector (#506)

* Use values instead of DataFrame for all modes of
SequentialFeatureSelector (fixes #505)

* Add bugfix description to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant