Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use values instead of DataFrame for all modes of SequentialFeatureSelector #506

Merged
merged 2 commits into from
Feb 16, 2019
Merged

Use values instead of DataFrame for all modes of SequentialFeatureSelector #506

merged 2 commits into from
Feb 16, 2019

Conversation

daniel-sch
Copy link
Contributor

@daniel-sch daniel-sch commented Feb 13, 2019

Description

SequentialFeatureSelector now supports DataFrame as input for all operating modes (forward/backward/floating).

Related issues or pull requests

Fixes #505

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

SequentialFeatureSelector (fixes #505)
@pep8speaks
Copy link

pep8speaks commented Feb 13, 2019

Hello @daniel-sch! Thanks for updating the PR.

Line 270:17: E117 over-indented

Comment last updated on February 13, 2019 at 14:37 Hours UTC

@coveralls
Copy link

coveralls commented Feb 13, 2019

Coverage Status

Coverage increased (+0.03%) to 91.617% when pulling fdc0e5d on daniel-sch:fix_dataframe_backward_feature_selection into 1ca3059 on rasbt:master.

@rasbt
Copy link
Owner

rasbt commented Feb 13, 2019

Nice, thanks. This could also help with #502 then!

@rasbt rasbt merged commit 8536994 into rasbt:master Feb 16, 2019
@daniel-sch daniel-sch deleted the fix_dataframe_backward_feature_selection branch February 26, 2019 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants