Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EyepadAlign for aligning face images across different datasets #466

Merged
merged 46 commits into from
Dec 9, 2018

Conversation

vmirly
Copy link
Contributor

@vmirly vmirly commented Nov 14, 2018

Description

Adding a new module called eyepad_align that aligns face images by fitting the location of eyes.

Furthermore, this technique can be used for aligning images across multiple datasets, where the images in one dataset will be transformed to the average location of eyes in another dataset.

Related issues or pull requests

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@pep8speaks
Copy link

pep8speaks commented Nov 14, 2018

Hello @vmirly! Thanks for updating the PR.

Line 23:1: E305 expected 2 blank lines after class or function definition, found 1

Line 75:80: E501 line too long (85 > 79 characters)
Line 76:48: E128 continuation line under-indented for visual indent

Line 153:80: E501 line too long (81 > 79 characters)

Comment last updated on December 09, 2018 at 18:35 Hours UTC

@coveralls
Copy link

coveralls commented Nov 14, 2018

Coverage Status

Coverage decreased (-0.2%) to 91.619% when pulling ac80d96 on vmirly:vm-eyepad into 18f0080 on rasbt:master.

@rasbt
Copy link
Owner

rasbt commented Nov 15, 2018

nice idea to use scikit-learn-like API for this. This way, it can be technically also used as a transformer in a scikit-learn pipeline.

@rasbt
Copy link
Owner

rasbt commented Nov 17, 2018

Adding a new class, mlxtend.image.EyepadAlign, that aligns face images by based on the eye location. Furthermore, this technique can be used for aligning images across multiple datasets, where the images in one dataset will be transformed to the average location of eyes in another dataset.

I think this would be a nice summary for the CHANGELOG then as well

@rasbt
Copy link
Owner

rasbt commented Nov 20, 2018

I think we should add a warning that individual pixel positions can be slightly different by 1-2 pixels on windows if users run the code on windows.

I can do that

@rasbt
Copy link
Owner

rasbt commented Dec 5, 2018

List of the todos we discussed as reference, so we don't forget

  • maintaining the folder structure
  • add option for nose-center alignment
  • add documentation to all methods
  • extend unit tests

@rasbt rasbt mentioned this pull request Dec 8, 2018
5 tasks
mlxtend/image/eyepad_align.py Outdated Show resolved Hide resolved
@rasbt rasbt merged commit f5d8d55 into rasbt:master Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants