Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing the indexes of landmark points #480

Closed
wants to merge 30 commits into from

Conversation

vmirly
Copy link
Contributor

@vmirly vmirly commented Dec 8, 2018

Description

Related issues or pull requests

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran nosetests ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., nosetests ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

vmirly and others added 29 commits November 14, 2018 11:11
@pep8speaks
Copy link

Hello @vmirly! Thanks for submitting the PR.

@rasbt
Copy link
Owner

rasbt commented Dec 8, 2018

oh wait, this is confusing, when we discussed this, I thought it was a separate PR. Now it appears that it adds all the other commits from #466 into this resulting in lots of duplicates

@rasbt
Copy link
Owner

rasbt commented Dec 8, 2018

I think the best option is if you could copy your changes, delete this PR, and add a fresh PR in a branch that doesn't have the commits from the EyepadAlign branch #466 (seems like you branched off of the #466 and forgot to change back to master before adding the notebook change)

@vmirly
Copy link
Contributor Author

vmirly commented Dec 8, 2018

Yes, this is messed up.

I will close this PR and create a new one.

@vmirly vmirly closed this Dec 8, 2018
@vmirly vmirly deleted the vm-landmarks branch December 8, 2018 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants