Make py3nvml optional #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnavigator
force-pushed
the
optional-py3nvml
branch
from
35e80a8
to
5fe85f2
Compare
rasbt
requested changes
Jul 2, 2023
| "available for this machine."} |
There was a problem hiding this comment.
So in that case, I'd say if py3nvml = None, we should probably then show a different message. I guess most users will interpret
"GPU information is not available for this machine."
as a GPU not being present or the GPU not being detected.
If someone uses the gpu flag and py3nvml = None, we should probably show something like
"Please install the py3nvml dependency (
pip install py3nvml) to display GPU information."
|
LGTM, thanks for the update! |
rasbt
approved these changes
Jul 2, 2023
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jul 4, 2023
https://build.opensuse.org/request/show/1096410 by user bnavigator + dimstar_suse - Update to 2.4.3 * Make py3nvml installation for GPU info optional. (replaces watermark-pr92-optional-py3nvml.patch) - Update to 2.4.2 * Adds a new --gpu flag to print out GPU information (currently limited to NVIDIA devices) (#90, via contribution by 907Resident) * (2.4.0 to 2.4.2: Packaging fixes) - Add watermark-pr92-optional-py3nvml.patch gh#rasbt/watermark#92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not everyone has or wants to install bindings for a proprietary NVIDIA library. Let's keep it optional.