Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
firmware: platform: Remove avoid_pwm_pll and make it enabled by defau…
…lt. PWM audio will always resample
- Loading branch information
1 parent
d56bf18
commit ba7a8fb
Showing
8 changed files
with
0 additions
and
0 deletions.
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
ba7a8fb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this change make the sound quality worse?
ba7a8fb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. The quality of the resampling is very much higher than the analogue audio quality.
Note: avoid_pwm_pll did used to harm quality by using a fractional clock. This commit does things a but differently.
When the de-popping was added a couple of years back we started resampling all analogue audio to 48KHz anyway. But 48KHz needs a dedicated PLL (or suffers from a fractional divide). This change makes the default output frequency 48.828125KHz which we can get from an existing PLL without a fractional divisor.
Feel free to test, but the resampling won't be audible.