-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPi3b+ boards are detected as RPi3b when using os_prefix option #1720
Comments
Please post the content of config.txt? You can omit blank lines and comments. |
This would be the config.txt:
|
Not sure if this is related but overlay_map.dtb and vc4-fkms-v3d are not loaded if os_prefix is set. But dwc2 is. And the DTB for 3b is loaded instead of 3b+?? I guess that would explain the MAC issue... Without os_prefix:
With os_prefix:
|
With
What do you have in your os_prefix folder? I created mine with:
|
|
It's looking as though there is an overall path limit of 63 bytes including the This restriction is completely unexpected - I thought the limit for prefix + file path (without |
So this is treated as a pi firmware bug then?
…On Tue, Apr 12, 2022 at 2:50 PM Phil Elwell ***@***.***> wrote:
It's looking as though there is an overall path limit of 63 bytes
including the /mfs/sd/ prefix) somewhere, which is shorter than I
expected. The longest dtb filename is 24 characters, which currently would
give a maximum os_prefix length of 30 characters. However, the longest
overlay name is 37 characters, plus 9 characters for overlays/, which
brings the maximum safe os_prefix directory name length down to a mere 8
characters.
This restriction is completely unexpected - I thought the limit for prefix
+ file path (without /mfs/sd/) would be over 80 characters, leading to a
maximum os_prefix of 40 characters, but the bottleneck appears to be lower
down the file handling stack.
—
Reply to this email directly, view it on GitHub
<#1720 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI7NWQ2ESLGZLXF24GTY3TVEVWRPANCNFSM5TDZ5URQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
It's somewhere between a bug and a limitation. I hope the limit can be increased, but there will always be a limit. What would you consider an acceptable maximum path length? |
Would you be happy with a maximum
|
To me, 64 max for os_prefix sounds reasonable, yes. |
Thanks. A patch implementing that change has been merged to our internal software repo, and will be in future firmware builds. |
Is this a 3b or 3b+? And curious, how do you account for potentially growing dtb filenames? Can the FW spit out some error if the resulting pathname is too long? |
Ah - that was the output from an intermediate version. A build with the final patch says:
The internal limit has been raised by 64 bytes, all of which are notionally given to os_prefix. This will leave enough headroom for an overlay name to be longer than the current champion by 7-8 bytes.
That would be a more invasive change than I would like. |
See: raspberrypi/linux#4983 kernel: vc4_hdmi: Remove VC4_HDMI_SCHEDULER_CONTROL_VERT_ALWAYS_KEEPOUT See: raspberrypi/linux#4972 firmware: arm_loader: Support longer file paths See: #1720
See: raspberrypi/linux#4983 kernel: vc4_hdmi: Remove VC4_HDMI_SCHEDULER_CONTROL_VERT_ALWAYS_KEEPOUT See: raspberrypi/linux#4972 firmware: arm_loader: Support longer file paths See: raspberrypi/firmware#1720
Updated firmware with increased |
I have checked that with latest firmware in master (4fe2e4a) things work as expected and my RPi3b+ is detected properly while having the relatively long |
Describe the bug
When using the os_prefix option, RPi3b+ boards are detected as RPi3b.
To reproduce
Copy dtbs, kernel, initrd, and cmdline.txt to a folder in the boot partition, and set
os_config=<dir>
in config.txt.Expected behaviour
An RPI3b+ should be detected:
(this is the behaviour when os_prefix is not used)
Actual behaviour
An RPI3b is detected:
One of the side effects that is produced is that the ethernet MAC is set to a randon number on each boot.
System
Pi3B+
cat /etc/rpi-issue
)?Ubuntu 22.04
vcgencmd version
)?1.20211118
uname -a
)?5.15.0
Logs
NA
Additional context
NA
The text was updated successfully, but these errors were encountered: