Skip to content

Commit

Permalink
lan78xx: Don't reset the interface on open
Browse files Browse the repository at this point in the history
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
  • Loading branch information
Phil Elwell authored and popcornmix committed Jun 27, 2018
1 parent 5be2dc7 commit 3ad3b8a
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/net/usb/lan78xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -2563,10 +2563,6 @@ static int lan78xx_open(struct net_device *net)
if (ret < 0)
goto out;

ret = lan78xx_reset(dev);
if (ret < 0)
goto done;

phy_start(net->phydev);

netif_dbg(dev, ifup, dev->net, "phy initialised successfully");
Expand Down

0 comments on commit 3ad3b8a

Please sign in to comment.