New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kernel oops adding eth0 to bridge on Pi3+ #2437
Comments
Bridging is an advanced use case that hasn't been tested here. The code path in question doesn't exist in the 4.14 kernel we will be switching to imminently. Can you run |
Still get an Oops with Linux version 4.14.26-v7+ (dc4@dc4-XPS13-9333) (gcc version 4.9.3 (crosstool-NG crosstool-ng-1.22.0-88-g8460611)) #1099 SMP Wed Mar 14 14:59:28 GMT 2018
|
I too am experiencing this on a RPi3 B-Plus (the RPi3 B works fine with the identical setup). I actually opened a ticket against systemd (using systemd-networkd to setup the bridge): systemd/systemd#8503 thinking it was to blame. Distro: Arch ARM (armv7h) |
This may have the same root cause as #2442, for which we are waiting for a patch to be completed and accepted upstream. |
@pelwell - Sounds good, thanks for the link. |
See: raspberrypi/linux#2458 kernel: Revert lan78xx: Simple patch to prevent some crashes kernel: lan78xx: Connect phy early kernel: lan78xx: Don't reset the interface on open See: raspberrypi/linux#2437 See: raspberrypi/linux#2442 See: raspberrypi/linux#2457 firmware: clockman: Don't use OSC for pixel clock See: https://www.raspberrypi.org/forums/viewtopic.php?f=29&t=24679&start=150#p1297298
See: raspberrypi/linux#2458 kernel: Revert lan78xx: Simple patch to prevent some crashes kernel: lan78xx: Connect phy early kernel: lan78xx: Don't reset the interface on open See: raspberrypi/linux#2437 See: raspberrypi/linux#2442 See: raspberrypi/linux#2457 firmware: clockman: Don't use OSC for pixel clock See: https://www.raspberrypi.org/forums/viewtopic.php?f=29&t=24679&start=150#p1297298
Latest rpi-update kernel has a potential fix for this issue. Please test. |
@popcornmix - Arch ARM doesn't use that script but I am building:
Will try and report back, thank you! |
Doesn't look like eth0 works at all now on the 3b+ even before being added to a bridge. Using a fresh 2018-03-13-raspbian-stretch-lite.img (with "enable_uart=1" added to config.txt) On first boot dhcpcd gets an IP on eth0 and it works OK. Run "sudo rpi-update"
And reboot eth0 no longer gets an IP address Even after assigning an IP/netmask to eth0 on the manually it's unable to ping the gateway/other IP in the subnet. |
...does this correspond to a commit in https://github.com/raspberrypi/firmware/commits/master ? I cannot find it. |
@graysky2 rpi-update gets firmware from https://github.com/Hexxeh/rpi-firmware |
@popcornmix - Thanks. To keep things simple, I will limit my replies to #2442 rather than mirroring them here. |
Looking at the output of ethtool before/after updating the only difference I could see was Trying to set it back to external with "sudo ethtool -s eth0 xcvr external" fails with the error
BUT from a fresh boot if I run "sudo ethtool -s eth0 xcvr internal" (even though it already says internal) I get an IPv6 address via NDP and DHCP obtains an IPv4 address a few seconds later and things work again. |
Thanks for the update. I've been investigating and the failure seems to be timing dependent - adding logging makes it go away (there may be a minimal useful set), and adding |
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
The code that enabled EEE mode was running at the point the interface was being opened. This forced a second round of negotiation, delaying readiness (sometimes permanently, depending on the timing). Moving the EEE enabling into the PHY initialisation function, immediately after the connection to the PHY is established, which is long before phy_start is called, prevents the renegotiation and avoids the slowdown (and occasional failure). |
Yes there was another issue, but my moving some of the initialisation code (c2eb306) I believe that issue has been resolved. |
With the rpi-update kernel after adding "dtparam=eee=off" eth0 links and works OK on fresh Raspbian and adding to a bridge also works OK. Recompiling with c2eb306 eth0 links OK (without "dtparam=eee=off") and can also be added to a bridge without Oops. |
Cool. I'll close the issue after the next firmware release. |
@pelwell Do you have a rough idea, when a fixed kernel and firmware will be released as deb package? |
The firmware could be released today (@popcornmix), and the .deb depends on @XECDesign. |
Given that there are several stability investigations ongoing, releasing a new .deb now would be premature. |
See: raspberrypi/linux#2437 kernel: config: Add BT_HCIUART_BCM=y and SERIAL_DEV_BUS=m See: raspberrypi/linux#2479 firmware: config: gpio - Allow pn (pull none) as alternative to np (no pull)
See: raspberrypi/linux#2437 kernel: config: Add BT_HCIUART_BCM=y and SERIAL_DEV_BUS=m See: raspberrypi/linux#2479 firmware: config: gpio - Allow pn (pull none) as alternative to np (no pull)
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: raspberrypi/linux#2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Enable EEE mode as soon as possible after connecting to the PHY, and before phy_start. This avoids a second link negotiation, which speeds up booting and stops the interface failing to become ready. See: #2437 Signed-off-by: Phil Elwell <phil@raspberrypi.org>
When adding eth0 to a bridge with a Pi3+ (Raspbian 2018-03-13) I get the following Oops on boot.
(full console output attached as startup.txt)
startup.txt
After the Oops Raspbian continues to boot but after many minutes doesn't get to the login prompt.
When the same SD card is used in a Pi3 (none +) it starts correctly and adds eth0 to br0.
To replicate - I'm using a fresh 2018-03-13-raspbian-stretch-lite.img with the following changes.
Add "enable_uart=1" to the end of /boot/config.txt
Boot & login
sudo apt-get update
sudo apt-get -y upgrade
sudo apt-get -y install bridge-utils
sudo cat << EOF | sudo tee -a /etc/network/interfaces
auto br0
iface br0 inet manual
bridge_ports eth0
bridge_stp off
bridge_waitport 0
bridge_fd 0
EOF
echo "denyinterfaces eth0" | sudo tee -a /etc/dhcpcd.conf
sudo reboot
On boot I get the Oops above.
The text was updated successfully, but these errors were encountered: