Skip to content

Commit

Permalink
lan78xx: Don't reset the interface on open
Browse files Browse the repository at this point in the history 
With Alexander Graf's patch ("lan78xx: Connect phy early") applied,
the call to lan78xx_reset within lan78xx_open prevents the phy
interrupt from being generated (even though the link is up).

Avoid this issue by removing the lan78xx_reset call.

See: #2437
     #2442
     #2457
  • Loading branch information
Phil Elwell committed Apr 4, 2018
1 parent c11ae4f commit b5b6bb9
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/net/usb/lan78xx.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2553,10 +2553,6 @@ static int lan78xx_open(struct net_device *net)
if (ret < 0)
goto out;

ret = lan78xx_reset(dev);
if (ret < 0)
goto done;

phy_start(net->phydev);

netif_dbg(dev, ifup, dev->net, "phy initialised successfully");
Expand Down

2 comments on commit b5b6bb9

@agraf
Copy link
Contributor

@agraf agraf commented on b5b6bb9 Apr 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been posted to the netdev ML? If not, please do so.

@pelwell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted.

Please sign in to comment.