Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute Module ignores i2c_arm from either config.txt or dt #1129

Closed
clivem opened this issue Sep 11, 2015 · 3 comments
Closed

Compute Module ignores i2c_arm from either config.txt or dt #1129

clivem opened this issue Sep 11, 2015 · 3 comments

Comments

@clivem
Copy link

clivem commented Sep 11, 2015

dtparam=i2c_arm=on in config.txt on compute module does not result in either i2c0 or i2c1 being enabled. I'd like it to enable i2c1 for compatibility with A+,B+ 2B.

The ignoring of anything referencing i2c_arm on CM also results in the lack of rtc being enabled using the "stock" i2c-rtc overlay definition, (config.txt: dtoverlay=i2c-rtc,ds1307), which references i2c_arm. Which of course can be worked around by specifying either i2c0 or i2c1 in the dts instead, but again, for consistencies sake and to allow the "stock" overlay definition to be used without any mods on all models including CM, it would be nice if either a ref to i2c_arm in either an overlay file or config.txt on CM, caused i2c1 to be enabled on CM.

EDIT: With the benefit of hindsight I should have opened this "issue" under the firmware project, rather than the kernel.... Sorry!!!
@clivem clivem changed the title Compute Module ignores i2c_arm from either confit.txt or dt Compute Module ignores i2c_arm from either config.txt or dt Sep 11, 2015
@pelwell
Copy link
Contributor

pelwell commented Sep 14, 2015

This could easily have been a DT/kernel issue, but as you've worked out the arm/vc aliases are created by the firmware. The thinking behind the absence of the aliases was that ownership of the ports is more flexible on the CM, and that CM users are likely to be creating their own .dtbs anyway.

Having said that, there's probably no harm in having the aliases created anyway. They should appear in a future release.

popcornmix added a commit to raspberrypi/firmware that referenced this issue Sep 14, 2015
@popcornmix
kernel: bump to 4.1.7
56d5a7b 
kernel: Revert "BCM270X_DT: mz61581: Revert to spi-bcm2708"
See: raspberrypi/linux#1132

kernel: bcm2835-mmc: Don't overwrite MMC capabilities from DT

kernel: BCM270X_DT: Use fixed-factor-clock for uart1
See: raspberrypi/linux#1008

kernel: vchiq: fix NULL pointer dereference when closing driver
See: raspberrypi/linux#1123

firmware: Fix touchscreen I2C to only read from i2c in smaller bursts to avoid a fifo overrun problem with the i2c peripheral
See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=120642

firmware: arm_display: Fix issue with nonsensical negative overscan settings
See: #471

firmware: arm_loader: Enable the i2c_arm and i2c_vc aliases for CM
See: raspberrypi/linux#1129

firmware: di_adv: Allow the v3d priority boost to be modified
See: http://forum.kodi.tv/showthread.php?tid=231092&pid=2103200#pid2103200
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this issue Sep 14, 2015
@popcornmix
kernel: bump to 4.1.7
6ade0ba 
kernel: Revert "BCM270X_DT: mz61581: Revert to spi-bcm2708"
See: raspberrypi/linux#1132

kernel: bcm2835-mmc: Don't overwrite MMC capabilities from DT

kernel: BCM270X_DT: Use fixed-factor-clock for uart1
See: raspberrypi/linux#1008

kernel: vchiq: fix NULL pointer dereference when closing driver
See: raspberrypi/linux#1123

firmware: Fix touchscreen I2C to only read from i2c in smaller bursts to avoid a fifo overrun problem with the i2c peripheral
See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=120642

firmware: arm_display: Fix issue with nonsensical negative overscan settings
See: raspberrypi/firmware#471

firmware: arm_loader: Enable the i2c_arm and i2c_vc aliases for CM
See: raspberrypi/linux#1129

firmware: di_adv: Allow the v3d priority boost to be modified
See: http://forum.kodi.tv/showthread.php?tid=231092&pid=2103200#pid2103200
@popcornmix
Copy link
Collaborator

@pelwell's change should be in latest rpi-update firmware

@clivem
Copy link
Author

clivem commented Sep 14, 2015

Tested using i2c_arm alias on CM with latest firmware. Working! Thank you.

@pelwell pelwell closed this as completed Sep 15, 2015
neuschaefer pushed a commit to neuschaefer/raspi-binary-firmware that referenced this issue Feb 27, 2017
@popcornmix
kernel: bump to 4.1.7
267b846 
kernel: Revert "BCM270X_DT: mz61581: Revert to spi-bcm2708"
See: raspberrypi/linux#1132

kernel: bcm2835-mmc: Don't overwrite MMC capabilities from DT

kernel: BCM270X_DT: Use fixed-factor-clock for uart1
See: raspberrypi/linux#1008

kernel: vchiq: fix NULL pointer dereference when closing driver
See: raspberrypi/linux#1123

firmware: Fix touchscreen I2C to only read from i2c in smaller bursts to avoid a fifo overrun problem with the i2c peripheral
See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=120642

firmware: arm_display: Fix issue with nonsensical negative overscan settings
See: raspberrypi#471

firmware: arm_loader: Enable the i2c_arm and i2c_vc aliases for CM
See: raspberrypi/linux#1129

firmware: di_adv: Allow the v3d priority boost to be modified
See: http://forum.kodi.tv/showthread.php?tid=231092&pid=2103200#pid2103200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@popcornmix @clivem @pelwell