Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "BCM270X_DT: mz61581: Revert to spi-bcm2708" #1132

Merged
merged 2 commits into from
Sep 13, 2015

Conversation

notro
Copy link
Contributor

@notro notro commented Sep 13, 2015

This reverts commit 1820cd0.

The spi-bcm2835 driver has been fixed, so now we can use it again.

Signed-off-by: Noralf Trønnes noralf@tronnes.org

This reverts commit 1820cd0.

The spi-bcm2835 driver has been fixed, so now we can use it again.

Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
@notro
Copy link
Contributor Author

notro commented Sep 13, 2015

Don't pull this yet, I have to change txbuflen to get good throughput. The dma mapping/engine overhead is high.

Because of the spi dma mapping/engine overhead with spi-bcm2835,
txbuflen has to be increased from 4096 to 32768 to maximize
throughput (11MB/s at 128MHz).

Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
@notro
Copy link
Contributor Author

notro commented Sep 13, 2015

Done updating PR.

@notro
Copy link
Contributor Author

notro commented Sep 13, 2015

For the SPI DMA curious:
A full display update is 300kB.
Using a 4k transmit buffer gives a measured throughput of 8MB/s at 128MHz (75 spi transfers).
Using a 32k buffer gives a throughput of 11 MB/s (10 spi transfers).

For comparison, the out-of-tree spi-bcm2708 can do 12MB/s with 4k buffers, but relies on the legacy DMA API.

pelwell added a commit that referenced this pull request Sep 13, 2015
Revert "BCM270X_DT: mz61581: Revert to spi-bcm2708"
@pelwell pelwell merged commit 291260a into raspberrypi:rpi-4.1.y Sep 13, 2015
@notro notro deleted the mz61581 branch September 13, 2015 15:53
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Sep 14, 2015
kernel: Revert "BCM270X_DT: mz61581: Revert to spi-bcm2708"
See: raspberrypi/linux#1132

kernel: bcm2835-mmc: Don't overwrite MMC capabilities from DT

kernel: BCM270X_DT: Use fixed-factor-clock for uart1
See: raspberrypi/linux#1008

kernel: vchiq: fix NULL pointer dereference when closing driver
See: raspberrypi/linux#1123

firmware: Fix touchscreen I2C to only read from i2c in smaller bursts to avoid a fifo overrun problem with the i2c peripheral
See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=120642

firmware: arm_display: Fix issue with nonsensical negative overscan settings
See: #471

firmware: arm_loader: Enable the i2c_arm and i2c_vc aliases for CM
See: raspberrypi/linux#1129

firmware: di_adv: Allow the v3d priority boost to be modified
See: http://forum.kodi.tv/showthread.php?tid=231092&pid=2103200#pid2103200
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Sep 14, 2015
kernel: Revert "BCM270X_DT: mz61581: Revert to spi-bcm2708"
See: raspberrypi/linux#1132

kernel: bcm2835-mmc: Don't overwrite MMC capabilities from DT

kernel: BCM270X_DT: Use fixed-factor-clock for uart1
See: raspberrypi/linux#1008

kernel: vchiq: fix NULL pointer dereference when closing driver
See: raspberrypi/linux#1123

firmware: Fix touchscreen I2C to only read from i2c in smaller bursts to avoid a fifo overrun problem with the i2c peripheral
See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=120642

firmware: arm_display: Fix issue with nonsensical negative overscan settings
See: raspberrypi/firmware#471

firmware: arm_loader: Enable the i2c_arm and i2c_vc aliases for CM
See: raspberrypi/linux#1129

firmware: di_adv: Allow the v3d priority boost to be modified
See: http://forum.kodi.tv/showthread.php?tid=231092&pid=2103200#pid2103200
neuschaefer pushed a commit to neuschaefer/raspi-binary-firmware that referenced this pull request Feb 27, 2017
kernel: Revert "BCM270X_DT: mz61581: Revert to spi-bcm2708"
See: raspberrypi/linux#1132

kernel: bcm2835-mmc: Don't overwrite MMC capabilities from DT

kernel: BCM270X_DT: Use fixed-factor-clock for uart1
See: raspberrypi/linux#1008

kernel: vchiq: fix NULL pointer dereference when closing driver
See: raspberrypi/linux#1123

firmware: Fix touchscreen I2C to only read from i2c in smaller bursts to avoid a fifo overrun problem with the i2c peripheral
See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=120642

firmware: arm_display: Fix issue with nonsensical negative overscan settings
See: raspberrypi#471

firmware: arm_loader: Enable the i2c_arm and i2c_vc aliases for CM
See: raspberrypi/linux#1129

firmware: di_adv: Allow the v3d priority boost to be modified
See: http://forum.kodi.tv/showthread.php?tid=231092&pid=2103200#pid2103200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants