Tidy up of the ft5406 driver to use DT #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesH65
force-pushed
the
ft5604_tidy
branch
from
7b93d49
to
5732e8a
Compare
pelwell
reviewed
Sep 4, 2017
| if (of_property_read_u32(np, "touchscreen-inverted-y", &val) >= 0) | ||
| ts->vflip = val; | ||
|
|
||
| if (of_property_read_u32(np, "touchscreen-swapped-x-y", &val) >= 0) { |
JamesH65
force-pushed
the
ft5604_tidy
branch
from
5732e8a
to
4a67afd
Compare
pelwell
reviewed
Sep 4, 2017
| touchscreen-size-x = <800>; | ||
| touchscreen-size-y = <600>; | ||
| touchscreen-inverted-x = <0>; | ||
| touchscreen-inverted-y = <0>; |
There was a problem hiding this comment.
git show is highlighting stray whitespace at the end of this line.
pelwell
reviewed
Sep 4, 2017
| __set_bit(EV_KEY, ts->input_dev->evbit); | ||
| __set_bit(EV_SYN, ts->input_dev->evbit); | ||
| __set_bit(EV_ABS, ts->input_dev->evbit); | ||
|
|
||
| input_set_abs_params(ts->input_dev, ABS_MT_POSITION_X, 0, | ||
| SCREEN_WIDTH, 0, 0); | ||
| ts->xyswap ? ts->max_y : ts->max_x, 0, 0); |
There was a problem hiding this comment.
The indentation on this and the next statement doesn't match the Linux style, which would use 3 TABs and 5 spaces.
pelwell
reviewed
Sep 4, 2017
JamesH65
force-pushed
the
ft5604_tidy
branch
from
4a67afd
to
6024a53
Compare
popcornmix
force-pushed
the
rpi-4.13.y
branch
from
c4aadf2
to
542d1c3
Compare
popcornmix
force-pushed
the
rpi-4.13.y
branch
3 times, most recently
from
3353d4d
to
871ca96
Compare
popcornmix
force-pushed
the
rpi-4.13.y
branch
2 times, most recently
from
cb6def4
to
0386d88
Compare
popcornmix
force-pushed
the
rpi-4.13.y
branch
3 times, most recently
from
7f47540
to
f4b3ddd
Compare
popcornmix
force-pushed
the
rpi-4.13.y
branch
from
f4b3ddd
to
ecbbac9
Compare
|
I've 'kernelified' this driver to coding standards (apart from a couple of warnings). I think this can be merged without the matching firmware change since any flips previously done automatically by the firmware side can now be achieved by using the device tree settings. |
|
Looks good to me. |
popcornmix
force-pushed
the
rpi-4.13.y
branch
from
fec87ed
to
b76f96e
Compare
|
Now updated to top of tree and can now be merged, if reviews OK. |
|
Sorry James - I've just spotted that you need to document the parameters in the README. And your commit message has a few typos. Otherwise it still looks good. |
6by9
reviewed
Nov 2, 2017
| &touchbuf, sizeof(touchbuf)); | ||
| dev_warn(dev, | ||
| "set failed, trying get" | ||
| " (err:%d touchbuf:%x virt:%p bus:%x)\n", |
There was a problem hiding this comment.
Checkpatch should have complained at that - strings presented to the user shouldn't be broken even if it does take the line over 80 chars.
popcornmix
force-pushed
the
rpi-4.13.y
branch
2 times, most recently
from
59341bd
to
de48202
Compare
popcornmix
force-pushed
the
rpi-4.13.y
branch
from
84cc9a9
to
2a25d75
Compare
popcornmix
pushed a commit
that referenced
this pull request
Jan 22, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Jan 22, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Jan 23, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Jan 24, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Feb 4, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Feb 4, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Feb 12, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Feb 12, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Feb 18, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Feb 18, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Feb 22, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Feb 24, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Mar 6, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Mar 6, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Mar 12, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Mar 12, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Mar 15, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Mar 15, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Mar 21, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Apr 2, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Apr 2, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Apr 8, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
Gadgetoid
pushed a commit
to Gadgetoid/linux
that referenced
this pull request
Apr 10, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Apr 23, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Apr 30, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
Apr 30, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
May 7, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
popcornmix
pushed a commit
that referenced
this pull request
May 13, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
TiejunChina
pushed a commit
that referenced
this pull request
Jun 19, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
TiejunChina
pushed a commit
that referenced
this pull request
Jul 23, 2019
Driver was using a fixed resolution, this commit adds touchscreen size, and coordinate flip and swap features via device tree overlays. Adds overrides so the VC4 can adjust the DT parameters appropriately; there is a newer version of the VC4 side driver that can now set up the appropriate DT values if required. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driver was using a fixed resolution, this commit
adds coordinate size, flip and swap features
via device tree.
Adds overrides so the VC4 can adjust the DT parameters
appropriately, there is a newer version of the VC4 side
driver that can now set up the appropriate DT values
if requried.