vc-cma: Remove the driver as non-functional on Pi #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vc-cma was pulled in from previous platforms. It supposedly allowed the VPU relocatable heap to be released to the kernel as CMA, but it was always a little fragile. Remove it to avoid complications. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
|
Reference #2114 where vc-cma was the cause of most of the reloc heap to be marked as offline, resulting in the camera failing. |
|
No objections from me. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Oct 20, 2017
kernel: vc-cma: Remove the driver as non-functional on Pi See: raspberrypi/linux#2233 firmware: Remove cmaservice as it doesn't work reliably
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Oct 20, 2017
kernel: vc-cma: Remove the driver as non-functional on Pi See: raspberrypi/linux#2233 firmware: Remove cmaservice as it doesn't work reliably
popcornmix
pushed a commit
that referenced
this pull request
Nov 21, 2023
[ Upstream commit 4f80050 ] Fix below checkpatch warning: WARNING: Missing a blank line after declarations #2233: FILE: drivers/net/can/usb/etas_es58x/es58x_core.c:2233: + int ret = es58x_init_netdev(es58x_dev, ch_idx); + if (ret) { Fixes: d8f26fd ("can: etas_es58x: remove es58x_get_product_info()") Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr> Link: https://lore.kernel.org/all/20230924110914.183898-3-mailhol.vincent@wanadoo.fr Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> Signed-off-by: Sasha Levin <sashal@kernel.org>
popcornmix
pushed a commit
that referenced
this pull request
Nov 21, 2023
[ Upstream commit 4f80050 ] Fix below checkpatch warning: WARNING: Missing a blank line after declarations #2233: FILE: drivers/net/can/usb/etas_es58x/es58x_core.c:2233: + int ret = es58x_init_netdev(es58x_dev, ch_idx); + if (ret) { Fixes: d8f26fd ("can: etas_es58x: remove es58x_get_product_info()") Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr> Link: https://lore.kernel.org/all/20230924110914.183898-3-mailhol.vincent@wanadoo.fr Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> Signed-off-by: Sasha Levin <sashal@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vc-cma was pulled in from previous platforms. It
supposedly allowed the VPU relocatable heap to be
released to the kernel as CMA, but it was always
a little fragile.
Remove it to avoid complications.
Signed-off-by: Dave Stevenson dave.stevenson@raspberrypi.org