Temporary reversions to fix vchiq #4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: raspberrypi#4016 This reverts commit 1c95454.
See: raspberrypi#4016 This reverts commit 4184da4.
See: raspberrypi#4016 This reverts commit 5d240a5.
See: raspberrypi#4016 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
|
Fixes the raspistill/raspivid seg faults. LGTM |
|
Any other comments? |
|
I haven't gone through the whole thing, but those reverts all seem reasonable. |
|
Merging on the basis that it has been seen to work, unlike the previous state. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Dec 22, 2020
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Dec 22, 2020
This was referenced Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something in the recent 5.10 upstream changes to vchiq (or possibly the lack of corresponding downstream changes) has broken bulk transfers in rpi-5.10.y. These three reversions and one fixup patch for vc-sm-cma are sufficient to get it working again while the real issue is root-caused.