Permanent fix for vchiq bulk transfer failures on 5.10 #4022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6by9
reviewed
Dec 22, 2020
|
The fix looks sane to me. Tested it fixes issue with vchiq_test -b 1000 |
The addition of the local 'userdata' pointer to vchiq_irq_queue_bulk_tx_rx omitted the case where neither BLOCKING nor WAITING modes are used, in which case the value provided by the caller is replaced with a NULL. Fixes: 4184da4 ("staging: vchiq: fix __user annotations") Signed-off-by: Phil Elwell <phil@raspberrypi.com>
|
I was going to leave the initialisation, but it's been removed now. |
|
Looks good. raspistill just captured an image for me. |
|
LGTM too. Raspistill and raspivid work as expected. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Dec 23, 2020
kernel: Permanent fix for vchiq bulk transfer failures on 5.10 See: raspberrypi/linux#4022
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Dec 23, 2020
kernel: Permanent fix for vchiq bulk transfer failures on 5.10 See: raspberrypi/linux#4022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix replaces #4016, reverting the reversions and applying a simple patch to fix the real bug, which was that the
userdatafor a bulk transfer was not preserved in the common case where a non-blocking transfer was being performed.@naushir,@6by9 If either of you are in a position to easily give this a spin I'd welcome the feedback, but vchiq_test in all its modes is happy (on 32-bit builds - 64-bit doesn't work with either fix...)