drm/vc4: Disable overrun interrupts #5935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a read-modify-write race when updating SCALER_DISPCTRL for underrun and end-of-frame interrupts. Ideally it would be fixed via a spinlock or similar, but that will require a reasonable amount of study to ensure we don't get deadlocks. The underrun reporting is only for debug, so disable it for now. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Feb 13, 2024
See: raspberrypi/linux#5930 kernel: drm/vc4: Disable overrun interrupts See: raspberrypi/linux#5935 kernel: drivers: thermal: step_wise: add support for hysteresis See: raspberrypi/linux#5936 kernel: media: rp1: cfe: Actually use the number of lanes configured See: raspberrypi/linux#5941 kernel: PCI: brcmstb: Enable CRS software visibility after linkup See: raspberrypi/linux#5889 kernel: SDHCI vs EMMC on Pi 5 See: raspberrypi/linux#5937
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Feb 13, 2024
See: raspberrypi/linux#5930 kernel: drm/vc4: Disable overrun interrupts See: raspberrypi/linux#5935 kernel: drivers: thermal: step_wise: add support for hysteresis See: raspberrypi/linux#5936 kernel: media: rp1: cfe: Actually use the number of lanes configured See: raspberrypi/linux#5941 kernel: PCI: brcmstb: Enable CRS software visibility after linkup See: raspberrypi/linux#5889 kernel: SDHCI vs EMMC on Pi 5 See: raspberrypi/linux#5937
This was referenced Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a read-modify-write race when updating SCALER_DISPCTRL for underrun and end-of-frame interrupts.
Ideally it would be fixed via a spinlock or similar, but that will require a reasonable amount of study to ensure we don't get deadlocks.
The underrun reporting is only for debug, so disable it for now.
#5674