Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vc4/hvs: Support fixed alpha correctly on 2712D0 #5930

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

popcornmix
Copy link
Collaborator

2712D0 removed alpha_mode from control word 2 for choosing fixed alpha and replaced it with the previously reserved value of 3 in alpha_mask.

Handle this to fix corrupt desktop when using X on 2712D0

@popcornmix
Copy link
Collaborator Author

Ping @6by9 @lurch

@6by9
Copy link
Contributor

6by9 commented Feb 6, 2024

Looks good.
Really minor nit would be for a blank line between the conditional and unconditional return lines.

@lurch
Copy link
Contributor

lurch commented Feb 7, 2024

Yup, after doing sudo rpi-update pulls/5930; sudo reboot X11 is now working perfectly fine on my 2712D0, both with and without glamor enabled 🎉

2712D0 removed alpha_mode from control word 2 for choosing fixed alpha
and replaced it with the previously reserved value of 3 in alpha_mask.

Handle this to fix corrupt desktop when using X on 2712D0

Signed-off-by: Dom Cobley <popcornmix@gmail.com>
@popcornmix
Copy link
Collaborator Author

Fixed nit.

@pelwell pelwell merged commit 0c8e9f7 into raspberrypi:rpi-6.6.y Feb 7, 2024
12 checks passed
@popcornmix popcornmix deleted the fixalphad0 branch February 7, 2024 13:54
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Feb 13, 2024
See: raspberrypi/linux#5930

kernel: drm/vc4: Disable overrun interrupts
See: raspberrypi/linux#5935

kernel: drivers: thermal: step_wise: add support for hysteresis
See: raspberrypi/linux#5936

kernel: media: rp1: cfe: Actually use the number of lanes configured
See: raspberrypi/linux#5941

kernel: PCI: brcmstb: Enable CRS software visibility after linkup
See: raspberrypi/linux#5889

kernel: SDHCI vs EMMC on Pi 5
See: raspberrypi/linux#5937
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this pull request Feb 13, 2024
See: raspberrypi/linux#5930

kernel: drm/vc4: Disable overrun interrupts
See: raspberrypi/linux#5935

kernel: drivers: thermal: step_wise: add support for hysteresis
See: raspberrypi/linux#5936

kernel: media: rp1: cfe: Actually use the number of lanes configured
See: raspberrypi/linux#5941

kernel: PCI: brcmstb: Enable CRS software visibility after linkup
See: raspberrypi/linux#5889

kernel: SDHCI vs EMMC on Pi 5
See: raspberrypi/linux#5937
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants