Add pio/ir_nec #129
Add pio/ir_nec #129
Conversation
added pio_ir_loopback example
IIRC it adds a URL string to the |
|
I wonder if your wiring diagram might be clearer if you used a black wire for GND and a red wire for 3V3? 🙂 |
Yes I think that's a very good idea - will do |
- README.adoc Clarify that the wavelength of the IR LED should be compatible with the detector used; Correct the number of jumper wires in the BOM. - Wiring diagram Use red wire for +3v3 and black for GND. - Fritzing source file Fix having added the wrong file. - ir_loopback/ir_loopback.c Correct typo in comment. - nec_receive_library/nec_receive.pio Amend comment to clarify that the provided 'init' function sets the state machine clock divider relative to the system clock. Amend comment to clarify that the 'init' function sets up the ISR as described.
Fixed by 0162c73 |
Ah, thanks - useful to know |
|
oops! |
|
bump |
|
bump again |
|
@lurch is this going anywhere please? |
|
It's out of my hands - it's up to @kilograham if he wants to take this any further... I think he's just very busy? |
|
@kilograham - please advise if this is of any interest, if not I will delete it |
|
Sorry, yes we are doing an example update now. @ghollingworth, @aallan is the license OK or do we need to add RPTL too? |
|
(Assuming the license situation is good) |
From my point of view, we're just fine with the original contributor retaining copyright so long as the license terms are clear and the code is submitted under a BSD 3 Clause. We don't necessarily demand (and haven't in the past) assignment of copyright for contributions that weren't work-for-hire. See this answer from @LizUpton on a similar topic in the documentation repo, raspberrypi/documentation#2079 (comment). |
|
Thanks all |
|
Can you add a link to the top level README.md for completeness |
As discussed with @lurch and referenced by @aallan this PR adds a PIO example to demonstrate sending and receiving infra-red codes in 'NEC' format:
pio/ir_nec.There are three sub-directories: the loopback example, and a library each for the transmit and receive functions. As requested I have included a README.adoc and wiring diagram along the lines of
gpio/hello_7segmentI've left my name in the copyright message with the BSD-3Clause licence but I'm OK for you to change that if necessary. Incidentally I have followed the format of the other examples by adding the
example_auto_set_url()stuff intoCMakeLists.txtbut I'm afraid I must admit I don't really know what I'm doing with that.