Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixup examples to use some SDK1.2.0 added functions #172

Merged
merged 1 commit into from
Oct 25, 2021
Merged

fixup examples to use some SDK1.2.0 added functions #172

merged 1 commit into from
Oct 25, 2021

Conversation

kilograham
Copy link
Contributor

No description provided.

@kilograham kilograham added this to the SDK 1.3.0 release milestone Oct 22, 2021
@kilograham kilograham self-assigned this Oct 22, 2021
@lurch
Copy link
Contributor

lurch commented Oct 25, 2021

These were (will be) added in SDK 1.3.0 not SDK 1.2.0 ? raspberrypi/pico-sdk#603

@kilograham
Copy link
Contributor Author

no, these were added in SDK1.2.0 but the examples were never updated

@kilograham kilograham merged commit fabb762 into develop Oct 25, 2021
@kilograham kilograham deleted the use_sdk120_functions branch October 25, 2021 17:30
@lurch
Copy link
Contributor

lurch commented Oct 25, 2021

no, these were added in SDK1.2.0 but the examples were never updated

https://github.com/raspberrypi/pico-sdk/blob/master/src/rp2_common/hardware_uart/include/hardware/uart.h doesn't contain uart_get_dreq, but https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/hardware_uart/include/hardware/uart.h does? 😕

(But of course it doesn't matter, now that this PR has been merged)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamfraser liamfraser liamfraser approved these changes

@Wren6991 Wren6991 Awaiting requested review from Wren6991

Assignees

@kilograham kilograham

Labels
None yet
Projects
None yet
Milestone
SDK 1.3.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@kilograham @lurch @liamfraser