Rename configNUMBER_OF_CORES to configNUM_CORES #1530
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Freertos SMP branch has been merged into main with configNUM_CORES renamed to configNUMBER_OF_CORES Fixes raspberrypi#1526
peterharperuk
force-pushed
the
fix_freertos_smp_cyw43_assert
branch
from
3c60415
to
c300901
Compare
gemarcano
added a commit
to gemarcano/snes_controllers_to_usb
that referenced
this pull request
Feb 15, 2024
- Software is based off my wifi pc remote button code, as well as my old SNES STM32 controller converter code for the TinyUSB descriptor. - This code relies on the following upstream PRs: - raspberrypi/pico-sdk#1530 - FreeRTOS/FreeRTOS-Kernel#991 - raspberrypi/pico-sdk#1635
|
It would be really great if this got merged. I just spent a bunch of time trying to get things working, only to figure out that it all wasn't working because the affinity set wasn't being updated since the pico SDK thinks that there is only one core (since it's looking at the wrong #define). At a minimum, maybe we could put an #error somewhere that indicates that FreeRTOS 11 is not supported yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Freertos SMP branch has been merged into main with configNUM_CORES renamed to configNUMBER_OF_CORES
Fixes #1526