Allow disabling pico_stdio function wrapping #1635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemarcano
added a commit
to gemarcano/snes_controllers_to_usb
that referenced
this pull request
Feb 15, 2024
- Software is based off my wifi pc remote button code, as well as my old SNES STM32 controller converter code for the TinyUSB descriptor. - This code relies on the following upstream PRs: - raspberrypi/pico-sdk#1530 - FreeRTOS/FreeRTOS-Kernel#991 - raspberrypi/pico-sdk#1635
|
Looks reasonable as far as I can see |
gemarcano
force-pushed
the
enable_stdio_wrap_disable
branch
from
e9097f3
to
ab72ea5
Compare
|
I noticed a useless newline I added in |
gemarcano
force-pushed
the
enable_stdio_wrap_disable
branch
from
ab72ea5
to
153e3d6
Compare
gemarcano
force-pushed
the
enable_stdio_wrap_disable
branch
from
153e3d6
to
13fbd73
Compare
gemarcano
force-pushed
the
enable_stdio_wrap_disable
branch
from
13fbd73
to
299fb53
Compare
- Copy the approach used by pico_printf and apply it to pico_stdio to allow a developer to opt out of stdio printf/putchar/etc. wrappers. - Add some #if/#endif around some functions that are not used if PICO_PRINTF_PICO isn't 1 to stop compiler warnings about unused functions.
gemarcano
force-pushed
the
enable_stdio_wrap_disable
branch
from
299fb53
to
310337e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR copies the approach used by pico_printf and applies it to pico_stdio to allow a developer to opt out of stdio printf/putchar/etc. wrappers. This is done with the use of a new function
pico_set_stdio_implementationwhich works identically topico_set_printf_implementationfrompico_printf.This enables a developer to opt out of stdio wrappers around the following functions:
Additionally, in
pico_stdio'sstdio.c, some additional#if/#endifare applied to shut up compiler warnings about unused functions whenpico_printfcompiler implementation is in use.Fixes #1634