Add call to tud_task in getchar() #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 13, 2022
liamfraser
previously approved these changes
Jul 14, 2022
|
ha, as I looked at this again, i realize it should be canceling the existing alarm.. i will add a fix |
kilograham
force-pushed
the
stdio_usb_getchar
branch
from
c739e13
to
c4338dc
Compare
lurch
reviewed
Jul 21, 2022
liamfraser
previously approved these changes
Jul 27, 2022
Wren6991
reviewed
Aug 8, 2022
Wren6991
approved these changes
Aug 8, 2022
cniles
pushed a commit
to cniles/pico-sdk
that referenced
this pull request
Aug 31, 2022
… alarm_pool_core_num() API (raspberrypi#918) This issue addresses possible starvation issues when using `getchar()` with `stdio_usb` and also fixes possible missing of IRQs as a result of raspberrypi#871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tud_task()during `getchar()tud_task()to not be called after an IRQ if the mutex wasn't available (previously we tried again automatically ever 1ms)