This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Update to gpiozero #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes final_code.py to use the gpiozero library instead of the RPi.GPIO module.
WillDereham
commented
Jun 5, 2017
| @@ -1,7 +1,7 @@ | |||
| #!/usr/bin/python3 | |||
| import pygame | |||
| import time | |||
| from RPi import GPIO | |||
| import gpiozero as gpio | |||
There was a problem hiding this comment.
Should I leave it as gpiozero, shorten it to gpio or just import the Button class? What would work for clarity?
Update to conform with the code changes in commit https://github.com/Epic0ne/morse-code-virtual-radio/commit/db0bbe809d89d986778650b155226e0938cbc20a The tutorial now uses gpiozero.
WillDereham
commented
Jun 5, 2017
| reading = GPIO.input(pin) | ||
| print("HIGH" if reading else "LOW") | ||
| reading = key.is_pressed | ||
| print("ON" if reading else "OFF") |
There was a problem hiding this comment.
Are ON and OFF appropriate names for the values? They aren't accurately represented by HIGH and LOW anymore, as that is handled internally by gpiozero, so should they be anything different, i.e UP and DOWN?
Missed this reference to `HIGH` and `LOW`
|
Finished and tested. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes final_code.py to use the gpiozero library instead of the
RPi.GPIO module. In response to issue #16 from @bennuttall . I still have to update the worksheet before it is ready to be merged.