Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate to ESM (ECMAScript Module) #115

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Translate to ESM (ECMAScript Module) #115

wants to merge 3 commits into from

Conversation

jaller94
Copy link
Collaborator

More and more of our dependencies transitioned to ESM.

To keep up with security fixes, it seems that we need to transition to ESM as well.

Merging after 1 week, if no one reviews this.

@rastapasta
Copy link
Owner

rastapasta commented May 3, 2022

Aloha @jaller94 - thanks for all your updates here, I'm a bit hesitant of merging them right away as I see it more as a decorative update of the code generated by your CoffeeScript converter.

Just to keep you in the loop, MapSCII v2 is slowly progressing in the currently limited free time (with some fundamental refactors for usability of MapSCII from inside other cli applications and a full switch, as already desired back then, to TypeScript). I would recommend limiting the time spent on updating/beautifying the current codebase - next to security patches. Cheers!

@jaller94
Copy link
Collaborator Author

Hi @rastapasta,

all my PRs so far have been hand-translated. I didn't use a converter.

This PR and #117 are pretty good refactors, even if Mapscii 2 is on its way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants