-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracing #26
Merged
Merged
Add tracing #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jisantuc
force-pushed
the
feature/js/add-tracing
branch
from
October 17, 2019 14:26
64c7979
to
6b49752
Compare
notthatbreezy
approved these changes
Oct 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - I pushed up the changes after our offline discussion on Resource
. If you want to clean that up a little more, I say go for it.
Open question on whether to bite the bullet and use log4cats
here too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR wires up work done in Raster Foundry's
http4s-util
subproject to add tracing to the one existing service. Tracing can be configured to point to xray or jaeger currently, but xray doesn't work for a confusing reason (probably because the http4s/circe/etc. versions bump to cats 2.0, see more in notes).Notes
The broken XRayTracer I think has to do with binary compatibility, but I'm not sure what's causing it in particular. An obvious guess was that since http4s is behind doobie and circe on cats-2.0 upgrades, I'd just need to download everything else, but I get the same error with doobie 0.7 and circe 0.11 as I do with doobie 0.8 and circe 0.12:
Testing Instructions
api/assembly
/api/hello/<name>
granary
service in Jaeger on 16686Closes #18