Moral degenerates

[sgillies]

Closes #18

[coveralls]

Coverage decreased (-0.07%) to 97.333% when pulling fcfbe8f on moral-degenerates into b225255 on master.

[sgillies]

@perrygeo I'm offering this one as an alternative to #19. This PR doesn't touch much of the implementation except to turn predicate properties that were using the global epsilon into methods that take a precision keyword argument (defaulting to 1.0e-5).

It also removes any precision from the degeneracy test, now it's just self.determinant == 0.0 and that seems to work fine.

I'm putting this on a 2.0 milestone because it's an API breaker.

[perrygeo]

This looks great. Def. a breaking change since many properties become methods. But I think it's a good move.

I wonder if we could apply the degeneracy test of self.determinant == 0.0 to the 1.2.x branch since that solves the original issue of certain raster affines being uninvertible with decimal degree units.

Also a left field, totally wacky idea to maintain backwards compatibility. I wonder if there is a way to create a hybrid property-method such that self.prop would dispatch to self.prop() and self.prop(**kwargs) would just work.

[coveralls]

Coverage increased (+2.6%) to 100.0% when pulling b7e3c59 on moral-degenerates into b225255 on master.

[sgillies]

Bonus 100% coverage :)

[perrygeo]

FWIW, I did find a way to make properties callable so that we could keep using them as properties or optionally as methods. Via @kezabelle : https://gist.github.com/kezabelle/43f45edefdcd1377b70eb171d4cffd1e#file-property_method-py

Not sure if this is something you'd be interested in implementing for the sake of backwards compat? But it proves that it can be done. Leaving it here just in case.

[sgillies]

@perrygeo I like it!

[coveralls]

Coverage increased (+1.9%) to 100.0% when pulling 4110dac on moral-degenerates into 0cd1cf2 on master.

[sgillies]

In the end, I think it's best for precision to be a Affine instance attribute and not add a complex descriptor.

[sgillies]

Please ignore the noise caused by my fumbling fingers.

[coveralls]

Coverage increased (+1.9%) to 100.0% when pulling 4110dac on moral-degenerates into 0cd1cf2 on master.