Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the EPSILON from a module-level global to a class property. Resolves #18
In order to avoid managing cache invalidation, I removed the concept of
cached_properties
. Most of those calculations take < 1/2 μs so I didn't see any performance reason for taking on that complexity. For example, thedeterminant
property takes 449ns to calculate and 300ns to lookup from the cache.Also removed the EPSILON2 global as it wasn't being used anywhere.
I'm not fully aware of the history of the codebase and removing the global EPSILON might be a breaking change. I'm not sold on this implementation, just a first cut.