Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python opener improvements needed #3039

Closed
sgillies opened this issue Mar 4, 2024 · 0 comments
Closed

Python opener improvements needed #3039

sgillies opened this issue Mar 4, 2024 · 0 comments
Assignees
@sgillies
Labels
bug
Milestone
1.4.0

Comments

@sgillies
Copy link
Member

sgillies commented Mar 4, 2024

In testing the use case of writing a shapefile to a python filesystem with fiona, I found some issues:

  • the Shapefile driver, at least, needs the flush callback.
  • the write callback returns the number of bytes, but is supposed to return the number of objects.
  • the Shapefile driver, at least, opens files in a mix of "w" and "r" modes when creating a new file. Thus, openers can't be registered to an access mode.

Porting recent changes back from fiona should be done before 1.4a3.
@sgillies sgillies added the bug label Mar 4, 2024
@sgillies sgillies added this to the 1.4.0 milestone Mar 4, 2024
@sgillies sgillies self-assigned this Mar 4, 2024
sgillies added a commit that referenced this issue Mar 5, 2024
@sgillies
Opener updates
c702587 
Resolves #3039
sgillies added a commit that referenced this issue Apr 8, 2024
@sgillies
Merge rel-1.4a2 branch (#3038)
413626b 
* Update version and change log

* as_posix() -> os.fspath()

* Do not resolve output files to absolute paths

* Set version to 1.4dev, will be merged back to main

* Opener updates

Resolves #3039

* Fix key for read_dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgillies sgillies

Labels
bug
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
1 participant
@sgillies