Updated platform array request interpretation handling and wrote tests.

src/helpers/__tests__/request_interpretation-test.js

@@ -20,6 +20,33 @@ describe.only('request interpretation', function() {
       function(){interpret.platformParameter(wrongQuery)}
     ).to.throw(InterpretError);
   });
+  it('platform array parameter', function() {
+    const emptyQuery = { };
+    const query = { "platform": 'soortenregister' };
+    const multipleQuery = { "platform": ['rijksmuseum', 'accurator'] };
+    const wrongQuery = { "platform": 'museum' };
+    const multipleWrongQuery = { "platform": ['museum', 'accurator'] };
+
+    expect(
+      interpret.platformArrayParameter(emptyQuery)
+    ).to.be.an('array');
+
+    expect(
+      interpret.platformArrayParameter(query)
+    ).to.deep.equal(['soortenregister']);
+
+    expect(
+      interpret.platformArrayParameter(multipleQuery)
+    ).to.deep.equal(['rijksmuseum', 'accurator']);
+
+    expect(
+      function(){interpret.platformArrayParameter(wrongQuery)}
+    ).to.throw(InterpretError);
+
+    expect(
+      function(){interpret.platformArrayParameter(multipleWrongQuery)}
+    ).to.throw(InterpretError);
+  });
   // it('object parameters', function() {
   //   let query = { "platform": 'soortenregister', "common_name": 'Rifleman' }
   //

src/helpers/request_interpretation.js

@@ -13,28 +13,10 @@ module.exports = {
   objectParameters: function(query, res) {
     // retrieve information about the requested bird and platforms
     return this.birdParameters(query, res).then(parameters => {
-      parameters.platforms = this.platformParameters(query, res);
+      parameters.platforms = this.platformArrayParameter(query);
       return parameters;
     });
   },
-  platformParameter: function(query) {
-    /* Return platform string based on url parameter
-     *
-     *  Three situations to handle:
-     *  1. No parameter given -> return null
-     *  2. Correct platform parameter -> return input
-     *  3. Platform does not exist -> 404 response & return false
-     */
-    let parameter = query.platform;
-
-    if (!parameter) throw new InterpretError('No platfom parameter provided', 400);
-
-    if (platforms.exists(parameter)) {
-      return parameter;
-    } else {
-      throw new InterpretError(`${parameter} platform parameter is unknown.`, 404);
-    }
-  },
   annotationParameters: function(query, res) {
     // retrieve one platform
     const platformId = this.platformParameter(query, res);
@@ -130,7 +112,7 @@ module.exports = {
 
     return date;
   },
-  platformParameters: function(query, res) {
+  platformArrayParameter: function(query) {
     /* Return array of platform strings based on url parameters
     *
     *  Three situations to handle:
@@ -151,13 +133,30 @@ module.exports = {
       if (platforms.exists(input[i])) {
         platformParameters.push(input[i]);
       } else {
-        res.status(404).send(`${input[i]} platform parameter is unknown.`);
-        return false;
+        throw new InterpretError(`${input[i]} platform parameter is unknown.`, 404);
       }
     }
 
     return platformParameters;
   },
+  platformParameter: function(query) {
+    /* Return platform string based on url parameter
+     *
+     *  Three situations to handle:
+     *  1. No parameter given -> return null
+     *  2. Correct platform parameter -> return input
+     *  3. Platform does not exist -> 404 response & return false
+     */
+    let parameter = query.platform;
+
+    if (!parameter) throw new InterpretError('No platfom parameter provided', 400);
+
+    if (platforms.exists(parameter)) {
+      return parameter;
+    } else {
+      throw new InterpretError(`${parameter} platform parameter is unknown.`, 404);
+    }
+  },
   verifyGenus: function(genus) {
     const url = `${platforms.platform('ioc').endpoint_location}/verify`;
     const query = { "genus": genus};