Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SECURITY: options.template allows arbitrary paths to be injected into tmp #156

Closed
8 tasks
silkentrance opened this issue Nov 27, 2017 · 3 comments
Closed
8 tasks
Labels

Comments

@silkentrance
Copy link
Collaborator

silkentrance commented Nov 27, 2017

Operating System

  • Linux
  • Windows 7
  • Windows 10
  • MacOS
  • other: all

NodeJS Version

  • 0.x
  • 4.x
  • 6.x
  • 7.x
  • other: all

Tmp Version

all existing and current code base.

Expected Behavior

options.template can contain arbitrary absolute or relative paths.

Experienced Behavior

Depending on the effective user, tmp will be able to create or delete or replace arbitrary files in the file system.

Security Concern

This can be a major security concern, depending on how applications make use of tmp.

@silkentrance
Copy link
Collaborator Author

This requires #143.

@silkentrance
Copy link
Collaborator Author

With #143 in place this should no longer be a problem unless one is capable of injecting paths relative to the configure default or user provided tmp dir.

@silkentrance
Copy link
Collaborator Author

Still a problem. Reopening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant