-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Temp file not working electron #176
Comments
According to the source of Could you verify that for me please by dumping the The following should work: console.log(JSON.stringify(process.env)) |
Could you please also show me what const os = require('os');
console.log(os.tmpdir()); |
This is working now: |
Could you please provide the requested information, so we could make sure that tmp works in electron on your Windows platform too? Thank you! |
@raszi I believe that tmp should fail early whenever it encounters an undefined tmpdir. What do you think? |
@silkentrance I believe that is a good idea! |
…ependency that somehow got lost
…ependency that somehow got lost
fix: fail early if there is no tmp dir specified
This was never fixed, at least not correctly. It will also break with the changes for #207 and the way that the dir option is being treated, which can no longer be an absolute path outside of the system's default. The correct behaviour should be for _getTmpDir() to throw an exception if the os.tmpDir() cannot be resolved as a path using path.resolve(). From the official electron docs https://www.electronjs.org/docs/all
So os.tmpdir() should be set and working around using app.getPath('temp') must not be used. |
Operating System
NodeJS Version
Tmp Version
TBD:Enter tmp version here
newest
Expected Behavior
TBD:What have you expected tmp to do?
correct temp file.
Experienced Behavior
TBD:What did actually happen?
It generates this file:
Then i trying to write to this file:
The text was updated successfully, but these errors were encountered: