Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation still refers to a template that provides paths #179

Closed
silkentrance opened this issue Oct 6, 2018 · 1 comment
Closed

Documentation still refers to a template that provides paths #179

silkentrance opened this issue Oct 6, 2018 · 1 comment
Labels
enhancement

Comments

@silkentrance
Copy link
Collaborator

See

https://github.com/raszi/node-tmp#asynchronous-filename-generation-1

The documentation must be updated, as this is no longer supported.
@raszi raszi closed this as completed in 40427ff Jan 29, 2019
raszi added a commit that referenced this issue Jan 29, 2019
@raszi
Merge pull request #180 from raszi/gh-179
0343c9e 
fix gh-179: template no longer accepts arbitrary paths
@silkentrance
Copy link
Collaborator Author

silkentrance commented Feb 6, 2020 •
edited
Loading

Reopening as the fix did not essentially fix the original problem.
The fix to this is that the template option must be relative to os.tmpdir().

@silkentrance silkentrance reopened this Feb 6, 2020
silkentrance added a commit that referenced this issue Feb 7, 2020
@silkentrance
fix #179 #207 #218 #176 #236 #237 #238
a4b0049
@silkentrance silkentrance mentioned this issue Apr 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@silkentrance