Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the style of application list #179

Closed
orhun opened this issue May 18, 2023 · 7 comments
Closed

Update the style of application list #179

orhun opened this issue May 18, 2023 · 7 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@orhun
Copy link
Sponsor Member

orhun commented May 18, 2023

Problem

See fdehau/tui-rs#704

Solution

We can possibly do a similar thing and split the applications into categories.

Alternatives

None.

Additional context

None.

@orhun orhun added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels May 18, 2023
@joshka
Copy link
Member

joshka commented May 19, 2023

Perhaps move this to a wiki page instead? My rationale is that adding an app to the source code of the library doesn't really seem like it is a meaningful feature. It's something that is about the library, not something that is part of the library.

I added https://github.com/tui-rs-revival/ratatui/wiki/Apps (which I copied from APPS.md)

It might be nice to have both tui and ratatui apps listed on that page with an indicator of which ones have been migrated.

Reorganizing that page is still worth keeping this issue open for though.

@thomas-mauran
Copy link
Contributor

If we split it in different categories should we keep them in different markdown tables ? or maybe have something like I proposed here, I don't know which one is more readable

@joshka
Copy link
Member

joshka commented May 19, 2023

I like your categories and subjectively prefer that suggested layout over the tables that we have currently. Any prefs @orhun?
I think I'd probably also drop the author like you have (as open source projects usually have multiple authors, and the main author is visible in the repo name).

@thomas-mauran
Copy link
Contributor

PR opened here we can work from that

@orhun
Copy link
Sponsor Member Author

orhun commented May 19, 2023

Yeah, I think we don't need the author.

@orhun
Copy link
Sponsor Member Author

orhun commented May 20, 2023

I added tui-rs-revival/ratatui/wiki/Apps (which I copied from APPS.md)

It makes sense to separate something which is not directly related to the library but in that case we need to make use of the Wiki more often to make it visible. Maybe after #184 is merged, we can remove that file and add a note in README.md about it is now a part of the Wiki or something. I'm okay with either way and I think having a separate file definitely makes the application list more apparent to the user. Need some comments on this so maybe create a issue/discussion?

@joshka
Copy link
Member

joshka commented May 21, 2023

Closing as merged (and the wiki conversation has moved to #185

@joshka joshka closed this as completed May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants