-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(span): add setters for content and style #647
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
=====================================
Coverage 90.8% 90.9%
=====================================
Files 42 42
Lines 12509 12533 +24
=====================================
+ Hits 11370 11394 +24
Misses 1139 1139 ☔ View full report in Codecov by Sentry. |
Actually these should be called "fluent setters" not "builder methods". Builder methods usually refer to a separate builder object that may have incomplete fields and need to be consumed to become the built object, e.g. https://docs.rs/typed-builder. |
Good point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as mentioned, we might change it to "fluent setters" before merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the typo, looks good
Rebased and squashed - should be good to go |
Co-authored-by: Valentin271 <36198422+Valentin271@users.noreply.github.com>
Tweaked must_use message to: #[must_use = "method moves the value of self and returns the modified value"] Based on discussion in #655 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me, approved
No description provided.