Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syn 1.x dependency reintroduced in 0.25 via stability crate #961

Closed
extrawurst opened this issue Feb 20, 2024 · 6 comments
Closed

syn 1.x dependency reintroduced in 0.25 via stability crate #961

extrawurst opened this issue Feb 20, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@extrawurst
Copy link

0.25 adds stability crate as a dependency which seems rather unmaintained and still depends on old syn 1.x.

is there an alternative that is more maintained and up to date? or is there a chance to get this update upstreamed into stabilty?

@extrawurst extrawurst added the enhancement New feature or request label Feb 20, 2024
@orhun
Copy link
Sponsor Member

orhun commented Feb 20, 2024

I'm guessing the reason why we depend on stability crate is that Rust does not support stability attributes (such as #[unstable(...)]) outside of the standard library. See rust-lang/rfcs#1491

I looked around in the Rust ecosystem a bit for a maintained alternative of stability crate but couldn't find anything. (Let me know if you know something!) So I believe I think it is best to upstream some changes for putting stability in a better shape.

@orhun
Copy link
Sponsor Member

orhun commented Feb 20, 2024

I updated the syn dependency in sagebind/stability#8, hopefully the maintainer will respond soon.

@orhun
Copy link
Sponsor Member

orhun commented Mar 24, 2024

Seems like that the maintainer of stability is not responding. Should fork it and release a new version on crates.io to get this moving? I looked for alternative crates but couldn't find any.

@extrawurst
Copy link
Author

@orhun that would be great 👍

@joshka
Copy link
Member

joshka commented Mar 25, 2024

Seems like that the maintainer of stability is not responding. Should fork it and release a new version on crates.io to get this moving? I looked for alternative crates but couldn't find any.

Looks like they are still fairly active on github, so it may just be a time thing. I'd generally prefer to work out a way that avoids forking something like this. Perhaps @sagebind would be amenable to adding one of us as a secondary maintainer? Can you reach out via email / socials?

If this wasn't a proc macro I'd just say bring in the source code directly and use it. But we'd need a separate library for this. It's a shame ratatui-macros is already taken (that probably should have been named tui-macros) as that would be a good place for proc macros that are necessary to be able to build ratatui like this to live.

sagebind pushed a commit to sagebind/stability that referenced this issue Apr 2, 2024
This PR updates the codebase to use the latest version of the `syn`
crate.

See ratatui-org/ratatui#961
@sww1235
Copy link

sww1235 commented Apr 16, 2024

looks like this was fixed in commit #b5061c5. Thanks for prodding sagebind XD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants