Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(breaking-changes): typos and markdownlint #1009

merged 3 commits into from
Apr 3, 2024


Copy link

No description provided. Outdated Show resolved Hide resolved
Copy link

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 nit Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.4%. Comparing base (26af650) to head (17855fa).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1009   +/-   ##
  Coverage   89.4%   89.4%           
  Files         61      61           
  Lines      15359   15430   +71     
+ Hits       13731   13799   +68     
- Misses      1628    1631    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

joshka commented Apr 3, 2024

LGTM - lint error is a false positive typo in a test

@joshka joshka merged commit 14461c3 into main Apr 3, 2024
32 of 33 checks passed
@joshka joshka deleted the breaking-change-md-minor-improvements branch April 3, 2024 09:07
joshka pushed a commit to nowNick/ratatui that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants