Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(calendar): use const fn #1039

Merged
merged 1 commit into from Apr 21, 2024
Merged

perf(calendar): use const fn #1039

merged 1 commit into from Apr 21, 2024

Conversation

EdJoPaTo
Copy link
Member

There are likely many more places where Style::default()Style::new() allows for const.

Also, do the comparison without as u8. Stays the same at runtime and is cleaner code.

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.4%. Comparing base (1126478) to head (b40d227).

Files Patch % Lines
src/widgets/calendar.rs 83.3% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1039   +/-   ##
=====================================
  Coverage   89.4%   89.4%           
=====================================
  Files         61      61           
  Lines      15430   15430           
=====================================
  Hits       13799   13799           
  Misses      1631    1631           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshka joshka merged commit 81b9633 into main Apr 21, 2024
32 of 33 checks passed
@joshka joshka deleted the calendar-const branch April 21, 2024 17:34
TadoTheMiner pushed a commit to TadoTheMiner/ratatui that referenced this pull request Apr 25, 2024
Also, do the comparison without `as u8`. Stays the same at runtime and
is cleaner code.
joshka pushed a commit to nowNick/ratatui that referenced this pull request May 24, 2024
Also, do the comparison without `as u8`. Stays the same at runtime and
is cleaner code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants