perf(table): const TableState::new

[EdJoPaTo]

Personally I think there should be either TableState::default() or TableState::new() but not both (#978). Here we have both, so at least allow for const fn new.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.4%. Comparing base (1126478) to head (fde4848).

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #1040   +/-   ##
=====================================
  Coverage   89.4%   89.4%           
=====================================
  Files         61      61           
  Lines      15430   15433    +3     
=====================================
+ Hits       13799   13802    +3     
  Misses      1631    1631           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joshka]

Personally I think there should be either TableState::default() or TableState::new() but not both (#978). Here we have both, so at least allow for const fn new.

The rationale behind having both new and default is from https://rust-lang.github.io/api-guidelines/interoperability.html#c-common-traits

Note that it is common and expected for types to implement both Default and an empty new constructor. new is the constructor convention in Rust, and users expect it to exist, so if it is reasonable for the basic constructor to take no arguments, then it should, even if it is functionally identical to default.