fix(examples): fix key handling in constraints #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add check for `KeyEventKind::Press` to constraints example's event handler to eliminate double keys on Windows.
psobolik
requested review from
orhun,
mindoodoo,
sayanarijit,
joshka,
kdheepak,
Valentin271 and
EdJoPaTo
as code owners
orhun
approved these changes
Apr 26, 2024
joshka
approved these changes
Apr 27, 2024
joshka
added a commit
to nowNick/ratatui
that referenced
this pull request
May 24, 2024
Add check for `KeyEventKind::Press` to constraints example's event handler to eliminate double keys on Windows. Fixes: ratatui-org#1062 --------- Co-authored-by: Josh McKinney <joshka@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check for
KeyEventKind::Pressto constraints example's event handler to eliminate double keyson Windows.
Fixes: #1062