fix(examples): changed user_input example to work with multi-byte unicode chars #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OkieOth
requested review from
orhun,
mindoodoo,
sayanarijit,
joshka,
kdheepak,
Valentin271 and
EdJoPaTo
as code owners
OkieOth
changed the title
kdheepak
changed the title
kdheepak
changed the title
joshka
approved these changes
Apr 27, 2024
|
I changed this a bit, to instead calculate the byte index and use that to insert. There's still a bug with displaying double width characters however. |
joshka
added a commit
to nowNick/ratatui
that referenced
this pull request
May 24, 2024
…code chars (ratatui-org#1069) This is the proposed solution for issue ratatui-org#1068. It solves the bug in the user_input example with multi-byte UTF-8 characters as input. Fixes: ratatui-org#1068 --------- Co-authored-by: Josh McKinney <joshka@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the proposed solution for issue #1068. It solves the bug in the user_input example with multi-byte UTF-8 characters as input.