fix(reflow): handle ZWSP #1074
Merged
fix(reflow): handle ZWSP #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kxxt
requested review from
orhun,
joshka,
kdheepak,
Valentin271 and
EdJoPaTo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1074 +/- ##
=====================================
Coverage 89.4% 89.4%
=====================================
Files 61 61
Lines 15462 15468 +6
=====================================
+ Hits 13833 13839 +6
Misses 1629 1629 ☔ View full report in Codecov by Sentry. |
orhun
reviewed
Apr 27, 2024
kxxt
force-pushed
the
fix/zwsp
branch
2 times, most recently
from
7b4c823
to
8f2df53
Compare
Handle ZWSP as a possible wrapping point.
orhun
approved these changes
Apr 28, 2024
joshka
approved these changes
Apr 28, 2024
kxxt
added a commit
to kxxt/tracexec
that referenced
this pull request
Apr 28, 2024
For now it doesn't correctly wrap at ZWSP. It will fixed by ratatui-org/ratatui#1074 in the next release of ratatui
joshka
pushed a commit
to nowNick/ratatui
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle ZWSP as a possible wrapping point.
See #293 (comment) for more details.