Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(buffer): fix Debug panic and fix formatting of overridden parts #1098

Merged
merged 4 commits into from
May 12, 2024

Conversation

EdJoPaTo
Copy link
Member

Fix panic in Debug for Buffer when width == 0.
Also corrects the output when symbols are overridden.


Let's do some final testing for #1007… test runner aborts on panic in panic handler. Nice. 👻

Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 98.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 94.2%. Comparing base (699c2d7) to head (7bf8a63).

Files Patch % Lines
src/buffer/buffer.rs 98.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1098   +/-   ##
=====================================
  Coverage   94.2%   94.2%           
=====================================
  Files         61      61           
  Lines      14530   14538    +8     
=====================================
+ Hits       13693   13701    +8     
  Misses       837     837           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/buffer/buffer.rs Outdated Show resolved Hide resolved
Copy link
Member

@joshka joshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking suggestions. Strong opinions weakly held here.

Can the commit message title be written in a more imperative form to describe the change in a way that makes more sense for the changelog? ("no" is ok here)

src/buffer/buffer.rs Outdated Show resolved Hide resolved
src/buffer/buffer.rs Outdated Show resolved Hide resolved
src/buffer/buffer.rs Show resolved Hide resolved
src/buffer/buffer.rs Outdated Show resolved Hide resolved
src/buffer/buffer.rs Outdated Show resolved Hide resolved
@EdJoPaTo EdJoPaTo changed the title fix(buffer): Debug panic and formatting fix(buffer): fix Debug panic and fix formatting of overridden parts May 12, 2024
@joshka joshka merged commit 366cbae into ratatui-org:main May 12, 2024
36 checks passed
@EdJoPaTo EdJoPaTo deleted the buffer-empty-debug-panic branch May 12, 2024 22:20
joshka pushed a commit to nowNick/ratatui that referenced this pull request May 24, 2024
…atatui-org#1098)

Fix panic in `Debug for Buffer` when `width == 0`.
Also corrects the output when symbols are overridden.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants