Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add underline-color to all features flag in makefile #1100

Merged
merged 3 commits into from
May 13, 2024

Conversation

joshka
Copy link
Member

@joshka joshka commented May 12, 2024

Ensures that we upload coverage details for the underline-color tests (at the expense of possible removing some coverage where the feature is not enabled). Given underline-color is a default feature this is sensible.

Also fixes up a small build warning that pops up when not building with the underline-color feature

Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.2%. Comparing base (ec763af) to head (582cf4a).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1100     +/-   ##
=======================================
- Coverage   94.2%   94.2%   -0.1%     
=======================================
  Files         61      61             
  Lines      14530   14540     +10     
=======================================
+ Hits       13693   13698      +5     
- Misses       837     842      +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdJoPaTo
Copy link
Member

cargo hack --keep-going --feature-powerset --no-dev-deps check might be a good idea…

@joshka
Copy link
Member Author

joshka commented May 12, 2024

cargo hack --keep-going --feature-powerset --no-dev-deps check might be a good idea…

I agree, it's outside the scope of this change however. Let's add that sometime.

@orhun
Copy link
Sponsor Member

orhun commented May 13, 2024

Agree with adding cargo-hack to the CI. Might be a good first issue even.

@joshka joshka merged commit 28e81c0 into main May 13, 2024
36 checks passed
@joshka joshka deleted the jm/underline-color-coverage branch May 13, 2024 08:34
joshka added a commit to nowNick/ratatui that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants